| Message ID | 20250219210302.442954-11-superm1@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | amd-pstate cleanups | expand |
On 2/20/2025 2:32 AM, Mario Limonciello wrote: > From: Mario Limonciello <mario.limonciello@amd.com> > > If a CPU is missing a policy or one has been offlined then the unit test > is skipped for the rest of the CPUs on the system. > > Instead; iterate online CPUs and skip any missing policies to allow > continuing to test the rest of them. > Reviewed-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com> > Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > v3: > * Only check online CPUs > * Update commit message > --- > drivers/cpufreq/amd-pstate-ut.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c > index 028527a0019ca..3a541780f374f 100644 > --- a/drivers/cpufreq/amd-pstate-ut.c > +++ b/drivers/cpufreq/amd-pstate-ut.c > @@ -116,12 +116,12 @@ static int amd_pstate_ut_check_perf(u32 index) > struct amd_cpudata *cpudata = NULL; > union perf_cached cur_perf; > > - for_each_possible_cpu(cpu) { > + for_each_online_cpu(cpu) { > struct cpufreq_policy *policy __free(put_cpufreq_policy) = NULL; > > policy = cpufreq_cpu_get(cpu); > if (!policy) > - break; > + continue; > cpudata = policy->driver_data; > > if (get_shared_mem()) { > @@ -188,12 +188,12 @@ static int amd_pstate_ut_check_freq(u32 index) > int cpu = 0; > struct amd_cpudata *cpudata = NULL; > > - for_each_possible_cpu(cpu) { > + for_each_online_cpu(cpu) { > struct cpufreq_policy *policy __free(put_cpufreq_policy) = NULL; > > policy = cpufreq_cpu_get(cpu); > if (!policy) > - break; > + continue; > cpudata = policy->driver_data; > > if (!((policy->cpuinfo.max_freq >= cpudata->nominal_freq) &&
diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c index 028527a0019ca..3a541780f374f 100644 --- a/drivers/cpufreq/amd-pstate-ut.c +++ b/drivers/cpufreq/amd-pstate-ut.c @@ -116,12 +116,12 @@ static int amd_pstate_ut_check_perf(u32 index) struct amd_cpudata *cpudata = NULL; union perf_cached cur_perf; - for_each_possible_cpu(cpu) { + for_each_online_cpu(cpu) { struct cpufreq_policy *policy __free(put_cpufreq_policy) = NULL; policy = cpufreq_cpu_get(cpu); if (!policy) - break; + continue; cpudata = policy->driver_data; if (get_shared_mem()) { @@ -188,12 +188,12 @@ static int amd_pstate_ut_check_freq(u32 index) int cpu = 0; struct amd_cpudata *cpudata = NULL; - for_each_possible_cpu(cpu) { + for_each_online_cpu(cpu) { struct cpufreq_policy *policy __free(put_cpufreq_policy) = NULL; policy = cpufreq_cpu_get(cpu); if (!policy) - break; + continue; cpudata = policy->driver_data; if (!((policy->cpuinfo.max_freq >= cpudata->nominal_freq) &&