| Message ID | 20250221030755.219277-1-wdhh66@163.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] scsi: fix missing lock protection | expand |
On 2/20/25 7:07 PM, Chaohai Chen wrote: > async_scan_lock is designed to protect the scanning_hosts list, > but there is no protection here. Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On Fri, 21 Feb 2025 11:07:55 +0800, Chaohai Chen wrote: > async_scan_lock is designed to protect the scanning_hosts list, > but there is no protection here. > > Applied to 6.15/scsi-queue, thanks! [1/1] scsi: fix missing lock protection https://git.kernel.org/mkp/scsi/c/ed3e4842224f
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 96d7e1a9a7c7..4833b8fe251b 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -151,8 +151,9 @@ int scsi_complete_async_scans(void) struct async_scan_data *data; do { - if (list_empty(&scanning_hosts)) - return 0; + scoped_guard(spinlock, &async_scan_lock) + if (list_empty(&scanning_hosts)) + return 0; /* If we can't get memory immediately, that's OK. Just * sleep a little. Even if we never get memory, the async * scans will finish eventually.
async_scan_lock is designed to protect the scanning_hosts list, but there is no protection here. Signed-off-by: Chaohai Chen <wdhh66@163.com> --- drivers/scsi/scsi_scan.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)