[RFC,BlueZ,1/9] org.bluez.MediaEndpoint: removing BAP streams with ClearConfiguration

Allow user to remove specific streams by calling
ClearConfiguration(transport_path) on the endpoint.  If the path is the
endpoint path instead, clear all streams associated with the endpoint.
---
 doc/org.bluez.MediaEndpoint.rst | 6 ++++++
 1 file changed, 6 insertions(+)

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=939281

---Test result---

Test Summary:
CheckPatch                    PENDING   0.24 seconds
GitLint                       PENDING   0.24 seconds
BuildEll                      PASS      20.51 seconds
BluezMake                     PASS      1476.20 seconds
MakeCheck                     PASS      13.02 seconds
MakeDistcheck                 PASS      160.25 seconds
CheckValgrind                 PASS      215.99 seconds
CheckSmatch                   WARNING   299.79 seconds
bluezmakeextell               PASS      98.83 seconds
IncrementalBuild              PENDING   0.30 seconds
ScanBuild                     PASS      883.73 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:305:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Hi Pauli,

On Sat, Mar 1, 2025 at 10:58 AM Pauli Virtanen <pav@iki.fi> wrote:
>
> Allow user to remove specific streams by calling
> ClearConfiguration(transport_path) on the endpoint.  If the path is the
> endpoint path instead, clear all streams associated with the endpoint.
> ---
>  doc/org.bluez.MediaEndpoint.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/org.bluez.MediaEndpoint.rst b/doc/org.bluez.MediaEndpoint.rst
> index f2b830ab0..b81106f0b 100644
> --- a/doc/org.bluez.MediaEndpoint.rst
> +++ b/doc/org.bluez.MediaEndpoint.rst
> @@ -109,6 +109,12 @@ void ClearConfiguration(object transport)
>
>         Clear transport configuration.
>
> +       **Server role:** [ISO only]
> +
> +       Close the stream associated with the given transport. If the
> +       path given is the path of this endpoint, all its streams are
> +       closed.

This seems sort of trivial, that said we can't really guarantee the
MediaTransports will be closed even if we send an ASCS_Release
operation the server may still cache the codec configuration.

>  void Release()
>  ``````````````
>
> --
> 2.48.1
>
>

Hi,

ma, 2025-03-17 kello 14:10 -0400, Luiz Augusto von Dentz kirjoitti:
> Hi Pauli,
> 
> On Sat, Mar 1, 2025 at 10:58 AM Pauli Virtanen <pav@iki.fi> wrote:
> > 
> > Allow user to remove specific streams by calling
> > ClearConfiguration(transport_path) on the endpoint.  If the path is the
> > endpoint path instead, clear all streams associated with the endpoint.
> > ---
> >  doc/org.bluez.MediaEndpoint.rst | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/doc/org.bluez.MediaEndpoint.rst b/doc/org.bluez.MediaEndpoint.rst
> > index f2b830ab0..b81106f0b 100644
> > --- a/doc/org.bluez.MediaEndpoint.rst
> > +++ b/doc/org.bluez.MediaEndpoint.rst
> > @@ -109,6 +109,12 @@ void ClearConfiguration(object transport)
> > 
> >         Clear transport configuration.
> > 
> > +       **Server role:** [ISO only]
> > +
> > +       Close the stream associated with the given transport. If the
> > +       path given is the path of this endpoint, all its streams are
> > +       closed.
> 
> This seems sort of trivial, that said we can't really guarantee the
> MediaTransports will be closed even if we send an ASCS_Release
> operation the server may still cache the codec configuration.

It does not work if we consider every ASE in Config Codec state is
associated with a transport. BAP Client should be able to fully control
what it transitions to QoS state, so transport = QoS state makes more
sense. (See also BAP §2.2.1.1 / 2.2.1.2)

Client must be able to transition from state where it e.g. uses sources
& sinks to a state where it only uses sink.

Some devices have restrictions that they cannot use sources with eg.
48kHz rate sinks together. The same devices may also always transition
all ASEs to Config Codec. As Client, we must be able to ignore some of
the configured ASEs, and transition to QoS only the ones we want to
use.