| Message ID | 20250225214909.4853-1-kartilak@cisco.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: fnic: Remove unnecessary debug print | expand |
Karan, > Remove unnecessary debug print from fdls_schedule_oxid_free_retry_work. > As suggested by Dan, this information is already present in > stack traces, and the kernel is not expected to fail small allocations. Applied to 6.15/scsi-staging, thanks!
diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c index 11211c469583..d12caede8919 100644 --- a/drivers/scsi/fnic/fdls_disc.c +++ b/drivers/scsi/fnic/fdls_disc.c @@ -323,10 +323,6 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work) spin_lock_irqsave(&fnic->fnic_lock, fnic->lock_flags); if (!reclaim_entry) { - FNIC_FCS_DBG(KERN_WARNING, fnic->host, fnic->fnic_num, - "Failed to allocate memory for reclaim struct for oxid idx: 0x%x\n", - idx); - schedule_delayed_work(&oxid_pool->schedule_oxid_free_retry, msecs_to_jiffies(SCHEDULE_OXID_FREE_RETRY_TIME)); spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);
Remove unnecessary debug print from fdls_schedule_oxid_free_retry_work. As suggested by Dan, this information is already present in stack traces, and the kernel is not expected to fail small allocations. Suggested-by: Dan Carpenter <dan.carpenter@linaro.org> Fixes: a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses") Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com> Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com> Reviewed-by: Arun Easi <aeasi@cisco.com> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com> --- drivers/scsi/fnic/fdls_disc.c | 4 ---- 1 file changed, 4 deletions(-)