| Message ID | 20250304143152.1799966-1-vladimir.zapolskiy@linaro.org |
|---|---|
| State | Accepted |
| Commit | d547913e87a6a40b8690c069492cddc0cef6c573 |
| Headers | show |
| Series | dt-bindings: clock: qcom,x1e80100-camcc: Fix the list of required-opps | expand |
On 04/03/2025 14:31, Vladimir Zapolskiy wrote: > The switch to multiple power domains implies that the required-opps > property shall be updated accordingly, a record in one property > corresponds to a record in another one. > > Fixes: 7ec95ff9abf4 ("dt-bindings: clock: move qcom,x1e80100-camcc to its own file") > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > --- > .../devicetree/bindings/clock/qcom,x1e80100-camcc.yaml | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml > index 5bbbaa15a260..938a2f1ff3fc 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml > @@ -40,9 +40,9 @@ properties: > - description: A phandle to the MMCX power-domain > > required-opps: > - maxItems: 1 > - description: > - A phandle to an OPP node describing MMCX performance points. > + items: > + - description: A phandle to an OPP node describing MXC performance points > + - description: A phandle to an OPP node describing MMCX performance points > > required: > - compatible > @@ -66,7 +66,8 @@ examples: > <&sleep_clk>; > power-domains = <&rpmhpd RPMHPD_MXC>, > <&rpmhpd RPMHPD_MMCX>; > - required-opps = <&rpmhpd_opp_low_svs>; > + required-opps = <&rpmhpd_opp_low_svs>, > + <&rpmhpd_opp_low_svs>; > #clock-cells = <1>; > #reset-cells = <1>; > #power-domain-cells = <1>; This patch is fine as there is no current upstream user that depends, there's no ABI impact. I'll take this into my tree as a precursor to a V5 camss bindings but, it'd be nice to get it merged ASAP. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml index 5bbbaa15a260..938a2f1ff3fc 100644 --- a/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,x1e80100-camcc.yaml @@ -40,9 +40,9 @@ properties: - description: A phandle to the MMCX power-domain required-opps: - maxItems: 1 - description: - A phandle to an OPP node describing MMCX performance points. + items: + - description: A phandle to an OPP node describing MXC performance points + - description: A phandle to an OPP node describing MMCX performance points required: - compatible @@ -66,7 +66,8 @@ examples: <&sleep_clk>; power-domains = <&rpmhpd RPMHPD_MXC>, <&rpmhpd RPMHPD_MMCX>; - required-opps = <&rpmhpd_opp_low_svs>; + required-opps = <&rpmhpd_opp_low_svs>, + <&rpmhpd_opp_low_svs>; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>;
The switch to multiple power domains implies that the required-opps property shall be updated accordingly, a record in one property corresponds to a record in another one. Fixes: 7ec95ff9abf4 ("dt-bindings: clock: move qcom,x1e80100-camcc to its own file") Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> --- .../devicetree/bindings/clock/qcom,x1e80100-camcc.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)