| Message ID | 20250307093309.44950-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] dt-bindings: rng: rockchip,rk3588-rng: Drop unnecessary status from example | expand |
On Fri, Mar 07, 2025 at 03:05:50PM +0100, Nicolas Frattaroli wrote: > On Friday, 7 March 2025 10:33:09 Central European Standard Time Krzysztof > Kozlowski wrote: > > Device nodes are enabled by default, so no need for 'status = "okay"' in > > the DTS example. > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > > Changes in v2: > > 1. Drop unnecessary full stop in subject prefix after ':'. > > 2. Add Rb tag. > > --- > > Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > > b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml index > > 757967212f55..ca71b400bcae 100644 > > --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > > +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > > @@ -53,7 +53,6 @@ examples: > > interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>; > > clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>; > > resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>; > > - status = "okay"; > > }; > > }; > > Hi, > > is there the possibility we could make dtschema as invoked by `make > dt_binding_check W=1` (or W=2) add a warning for examples that have disabled > or explicitly listed status properties when not needed? Or is this something > better handled in, say, checkpatch.pl? > > The question arises because dumb mistakes by me like this should ideally be > caught before they waste precious maintainer time. > > If it's best handled in dtschema, I can look into working on that so you guys > don't have to do even more work due to me. Trust me, I'm always looking for things to check automatically. :) I have something like that which adds a schema for examples only. I think there were some corner cases. I'll take a fresh look at it. Rob
On Fri, 07 Mar 2025 10:33:09 +0100, Krzysztof Kozlowski wrote: > Device nodes are enabled by default, so no need for 'status = "okay"' in > the DTS example. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes in v2: > 1. Drop unnecessary full stop in subject prefix after ':'. > 2. Add Rb tag. > --- > Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
On Mon, Mar 10, 2025 at 7:49 AM Rob Herring <robh@kernel.org> wrote: > > On Fri, Mar 07, 2025 at 03:05:50PM +0100, Nicolas Frattaroli wrote: > > On Friday, 7 March 2025 10:33:09 Central European Standard Time Krzysztof > > Kozlowski wrote: > > > Device nodes are enabled by default, so no need for 'status = "okay"' in > > > the DTS example. > > > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > > --- > > > > > > Changes in v2: > > > 1. Drop unnecessary full stop in subject prefix after ':'. > > > 2. Add Rb tag. > > > --- > > > Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > > > b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml index > > > 757967212f55..ca71b400bcae 100644 > > > --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > > > +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml > > > @@ -53,7 +53,6 @@ examples: > > > interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>; > > > clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>; > > > resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>; > > > - status = "okay"; > > > }; > > > }; > > > > Hi, > > > > is there the possibility we could make dtschema as invoked by `make > > dt_binding_check W=1` (or W=2) add a warning for examples that have disabled > > or explicitly listed status properties when not needed? Or is this something > > better handled in, say, checkpatch.pl? > > > > The question arises because dumb mistakes by me like this should ideally be > > caught before they waste precious maintainer time. > > > > If it's best handled in dtschema, I can look into working on that so you guys > > don't have to do even more work due to me. > > Trust me, I'm always looking for things to check automatically. :) > > I have something like that which adds a schema for examples only. I > think there were some corner cases. I'll take a fresh look at it. I got my check working again. i2c/i2c-demux-pinctrl.yaml is the problematic one. Not sure what to do there. Rob
diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml index 757967212f55..ca71b400bcae 100644 --- a/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3588-rng.yaml @@ -53,7 +53,6 @@ examples: interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>; clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>; resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>; - status = "okay"; }; };