| Message ID | 2144b990-e584-4f77-a3be-5987b56d051a@stanley.mountain |
|---|---|
| State | Accepted |
| Commit | 3144ba2a70e6d5065e9bb8d573268e7e05cc84c8 |
| Headers | show |
| Series | Bluetooth: Fix error code in chan_alloc_skb_cb() | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=942410 ---Test result--- Test Summary: CheckPatch PENDING 0.33 seconds GitLint PENDING 0.20 seconds SubjectPrefix PASS 0.09 seconds BuildKernel PASS 24.83 seconds CheckAllWarning PASS 27.57 seconds CheckSparse PASS 30.95 seconds BuildKernel32 PASS 24.46 seconds TestRunnerSetup PASS 437.95 seconds TestRunner_l2cap-tester PASS 21.24 seconds TestRunner_iso-tester PASS 35.47 seconds TestRunner_bnep-tester PASS 4.82 seconds TestRunner_mgmt-tester FAIL 122.10 seconds TestRunner_rfcomm-tester PASS 7.94 seconds TestRunner_sco-tester PASS 11.79 seconds TestRunner_ioctl-tester PASS 8.44 seconds TestRunner_mesh-tester FAIL 6.34 seconds TestRunner_smp-tester PASS 7.37 seconds TestRunner_userchan-tester PASS 5.08 seconds IncrementalBuild PENDING 0.79 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4 Failed Test Cases LL Privacy - Set Flags 2 (Enable RL) Failed 0.143 seconds ############################## Test: TestRunner_mesh-tester - FAIL Desc: Run mesh-tester with test-runner Output: BUG: KASAN: slab-use-after-free in run_timer_softirq+0x76f/0x7d0 WARNING: CPU: 0 PID: 65 at kernel/workqueue.c:2257 __queue_work+0x687/0xb40 Total: 10, Passed: 9 (90.0%), Failed: 1, Not Run: 0 Failed Test Cases Mesh - Send cancel - 1 Failed 0.112 seconds ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index 50cfec8ccac4..3c29778171c5 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan.c @@ -825,11 +825,16 @@ static struct sk_buff *chan_alloc_skb_cb(struct l2cap_chan *chan, unsigned long hdr_len, unsigned long len, int nb) { + struct sk_buff *skb; + /* Note that we must allocate using GFP_ATOMIC here as * this function is called originally from netdev hard xmit * function in atomic context. */ - return bt_skb_alloc(hdr_len + len, GFP_ATOMIC); + skb = bt_skb_alloc(hdr_len + len, GFP_ATOMIC); + if (!skb) + return ERR_PTR(-ENOMEM); + return skb; } static void chan_suspend_cb(struct l2cap_chan *chan)
The chan_alloc_skb_cb() function is supposed to return error pointers on error. Returning NULL will lead to a NULL dereference. Fixes: 6b8d4a6a0314 ("Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- net/bluetooth/6lowpan.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)