diff mbox series

[2/7] mmc-utils: lsmmc: Remove redundant argument checks in do_read_<reg>

Message ID 20250310055231.304728-3-avri.altman@sandisk.com
State New
Headers show
Series mmc-utils: lsmmc: Registers value as an argument | expand

Commit Message

Avri Altman March 10, 2025, 5:52 a.m. UTC 
This commit removes unnecessary argument checks in the do_read_csd,
do_read_cid, and do_read_scr functions. The checks are redundant because
the use of optarg in do_read_reg already ensures that all necessary
arguments are provided and validated.

The optarg mechanism in do_read_reg inherently handles argument
validation, making these additional checks superfluous. This simplifies
the code and avoids redundant checks.

Signed-off-by: Avri Altman <avri.altman@sandisk.com>
---
 lsmmc.c | 15 ---------------
 1 file changed, 15 deletions(-)
diff mbox series

Patch

diff --git a/lsmmc.c b/lsmmc.c
index bc0e264..468a533 100644
--- a/lsmmc.c
+++ b/lsmmc.c
@@ -2192,30 +2192,15 @@  static int do_read_reg(int argc, char **argv, enum REG_TYPE reg)
 
 int do_read_csd(int argc, char **argv)
 {
-	if (argc != 2 && argc != 3) {
-		fprintf(stderr, "Usage: Print CSD data from <device path>.\n");
-		exit(1);
-	}
-
 	return do_read_reg(argc, argv, CSD);
 }
 
 int do_read_cid(int argc, char **argv)
 {
-	if (argc != 2 && argc != 3) {
-		fprintf(stderr, "Usage: Print CID data from <device path>.\n");
-		exit(1);
-	}
-
 	return do_read_reg(argc, argv, CID);
 }
 
 int do_read_scr(int argc, char **argv)
 {
-	if (argc != 2 && argc != 3) {
-		fprintf(stderr, "Usage: Print SCR data from <device path>.\n");
-		exit(1);
-	}
-
 	return do_read_reg(argc, argv, SCR);
 }