diff mbox series

Bluetooth: btmtksdio: Prevent enabling interrupts after IRQ handler removal

Message ID 20250312012522.53604-1-sean.wang@kernel.org
State New
Headers show
Series Bluetooth: btmtksdio: Prevent enabling interrupts after IRQ handler removal | expand

Commit Message

Sean Wang March 12, 2025, 1:25 a.m. UTC 
From: Sean Wang <sean.wang@mediatek.com>

Ensure interrupts are not re-enabled when the IRQ handler has already been
removed. This prevents unexpected IRQ handler execution due to stale or
unhandled interrupts.

Modify btmtksdio_txrx_work to check if bdev->func->irq_handler exists
before calling sdio_writel to enable interrupts.

Co-developed-by: Pedro Tsai <pedro.tsai@mediatek.com>
Signed-off-by: Pedro Tsai <pedro.tsai@mediatek.com>
Co-developed-by: Felix Freimann <felix.freimann@mediatek.com>
Signed-off-by: Felix Freimann <felix.freimann@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
 drivers/bluetooth/btmtksdio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

patchwork-bot+bluetooth@kernel.org March 20, 2025, 7 p.m. UTC | #1 
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 11 Mar 2025 18:25:22 -0700 you wrote:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> Ensure interrupts are not re-enabled when the IRQ handler has already been
> removed. This prevents unexpected IRQ handler execution due to stale or
> unhandled interrupts.
> 
> Modify btmtksdio_txrx_work to check if bdev->func->irq_handler exists
> before calling sdio_writel to enable interrupts.
> 
> [...]

Here is the summary with links:
  - Bluetooth: btmtksdio: Prevent enabling interrupts after IRQ handler removal
    https://git.kernel.org/bluetooth/bluetooth-next/c/01c13f057bb7

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index bd5464bde174..edd5eead1e93 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -610,7 +610,8 @@  static void btmtksdio_txrx_work(struct work_struct *work)
 	} while (int_status || time_is_before_jiffies(txrx_timeout));
 
 	/* Enable interrupt */
-	sdio_writel(bdev->func, C_INT_EN_SET, MTK_REG_CHLPCR, NULL);
+	if (bdev->func->irq_handler)
+		sdio_writel(bdev->func, C_INT_EN_SET, MTK_REG_CHLPCR, NULL);
 
 	sdio_release_host(bdev->func);