| Message ID | 20250314-acpm-fixes-v1-2-ab03ca8e723f@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | firmware: exynos-acpm: read fix & reduce log verbosity | expand |
On 3/17/25 10:26 AM, Tudor Ambarus wrote: > > > On 3/14/25 4:40 PM, André Draszik wrote: >> This driver emits error messages when client drivers are trying to get >> an interface handle to this driver here before this driver has >> completed _probe(). >> >> Given this driver returns -EPROBE_DEFER in that case, this is not an >> error and shouldn't be emitted to the log, so just remove them. >> >> Fixes: a88927b534ba ("firmware: add Exynos ACPM protocol driver") >> Signed-off-by: André Draszik <andre.draszik@linaro.org> > > Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> I see you kept the error message though for of_find_device_by_node() failure. You either get rid of that too, or maybe transform all to dev_dbg?
On Mon, 2025-03-17 at 10:48 +0000, Tudor Ambarus wrote: > > > On 3/17/25 10:26 AM, Tudor Ambarus wrote: > > > > > > On 3/14/25 4:40 PM, André Draszik wrote: > > > This driver emits error messages when client drivers are trying to get > > > an interface handle to this driver here before this driver has > > > completed _probe(). > > > > > > Given this driver returns -EPROBE_DEFER in that case, this is not an > > > error and shouldn't be emitted to the log, so just remove them. > > > > > > Fixes: a88927b534ba ("firmware: add Exynos ACPM protocol driver") > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > > > Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > > I see you kept the error message though for of_find_device_by_node() > failure. You either get rid of that too, or maybe transform all to dev_dbg? Thanks Tudor. Seems I missed that, I'll remove it, too. Cheers, A.
diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c index a85b2dbdd9f0d7b1f327f54a0a283e4f32587a98..48f1e3cacaa709ae703115169df138b659ddae44 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -690,14 +690,11 @@ static const struct acpm_handle *acpm_get_by_phandle(struct device *dev, acpm = platform_get_drvdata(pdev); if (!acpm) { - dev_err(dev, "Cannot get drvdata from %s\n", - dev_name(&pdev->dev)); platform_device_put(pdev); return ERR_PTR(-EPROBE_DEFER); } if (!try_module_get(pdev->dev.driver->owner)) { - dev_err(dev, "Cannot get module reference.\n"); platform_device_put(pdev); return ERR_PTR(-EPROBE_DEFER); }
This driver emits error messages when client drivers are trying to get an interface handle to this driver here before this driver has completed _probe(). Given this driver returns -EPROBE_DEFER in that case, this is not an error and shouldn't be emitted to the log, so just remove them. Fixes: a88927b534ba ("firmware: add Exynos ACPM protocol driver") Signed-off-by: André Draszik <andre.draszik@linaro.org> --- issue is in linux-next only afaics at this stage, as driver is not merged into Linus' tree yet --- drivers/firmware/samsung/exynos-acpm.c | 3 --- 1 file changed, 3 deletions(-)