| Message ID | 20250322103606.680401-7-lkml@antheas.dev |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hwmon: (oxpsensors) Add devices, features, fix ABI and move to platform/x86 | expand |
On Sat, 22 Mar 2025, Antheas Kapenekakis wrote: > Currently, the EC group is used for the turbo button. However, the next > patch in the series adds support for the LED button in X1 devices, which > is only applicable for X1 devices. Therefore, rename it to prepare for > adding the second group. And make it const while at it. > > Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com> > Reviewed-by: Thomas Weißschuh <linux@weissschuh.net> > Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> > --- > drivers/platform/x86/oxpec.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c > index dc3a0871809cd..ee37070ec54fc 100644 > --- a/drivers/platform/x86/oxpec.c > +++ b/drivers/platform/x86/oxpec.c > @@ -681,18 +681,18 @@ static const struct hwmon_channel_info * const oxp_platform_sensors[] = { > NULL, > }; > > -static struct attribute *oxp_ec_attrs[] = { > +static struct attribute *oxp_tt_toggle_attrs[] = { > &dev_attr_tt_toggle.attr, > NULL > }; > > -static struct attribute_group oxp_ec_attribute_group = { > +static const struct attribute_group oxp_tt_toggle_attribute_group = { > .is_visible = tt_toggle_is_visible, > - .attrs = oxp_ec_attrs, > + .attrs = oxp_tt_toggle_attrs, > }; > > static const struct attribute_group *oxp_ec_groups[] = { > - &oxp_ec_attribute_group, > + &oxp_tt_toggle_attribute_group, > NULL > }; Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c index dc3a0871809cd..ee37070ec54fc 100644 --- a/drivers/platform/x86/oxpec.c +++ b/drivers/platform/x86/oxpec.c @@ -681,18 +681,18 @@ static const struct hwmon_channel_info * const oxp_platform_sensors[] = { NULL, }; -static struct attribute *oxp_ec_attrs[] = { +static struct attribute *oxp_tt_toggle_attrs[] = { &dev_attr_tt_toggle.attr, NULL }; -static struct attribute_group oxp_ec_attribute_group = { +static const struct attribute_group oxp_tt_toggle_attribute_group = { .is_visible = tt_toggle_is_visible, - .attrs = oxp_ec_attrs, + .attrs = oxp_tt_toggle_attrs, }; static const struct attribute_group *oxp_ec_groups[] = { - &oxp_ec_attribute_group, + &oxp_tt_toggle_attribute_group, NULL };