| Message ID | 20250324102142.67022-4-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | gdbstub: conversion to runtime endianess helpers | expand |
On 3/24/25 03:21, Alex Bennée wrote: > When things go wrong we want to assert on the register that failed to > be able to figure out what went wrong. > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > gdbstub/gdbstub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > index 282e13e163..b6d5e11e03 100644 > --- a/gdbstub/gdbstub.c > +++ b/gdbstub/gdbstub.c > @@ -1328,8 +1328,8 @@ static void handle_read_all_regs(GArray *params, void *user_ctx) > len += gdb_read_register(gdbserver_state.g_cpu, > gdbserver_state.mem_buf, > reg_id); > + g_assert(len == gdbserver_state.mem_buf->len); > } > - g_assert(len == gdbserver_state.mem_buf->len); > > gdb_memtohex(gdbserver_state.str_buf, gdbserver_state.mem_buf->data, len); > gdb_put_strbuf(); Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 282e13e163..b6d5e11e03 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1328,8 +1328,8 @@ static void handle_read_all_regs(GArray *params, void *user_ctx) len += gdb_read_register(gdbserver_state.g_cpu, gdbserver_state.mem_buf, reg_id); + g_assert(len == gdbserver_state.mem_buf->len); } - g_assert(len == gdbserver_state.mem_buf->len); gdb_memtohex(gdbserver_state.str_buf, gdbserver_state.mem_buf->data, len); gdb_put_strbuf();