| Message ID | 20250325213230.2513331-1-luiz.dentz@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ,v1] main: Fix handling of legacy experimental LL Privacy | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=947309 ---Test result--- Test Summary: CheckPatch PENDING 0.19 seconds GitLint PENDING 0.17 seconds BuildEll PASS 20.69 seconds BluezMake PASS 1528.37 seconds MakeCheck PASS 12.84 seconds MakeDistcheck PASS 161.08 seconds CheckValgrind PASS 216.07 seconds CheckSmatch PASS 286.94 seconds bluezmakeextell PASS 98.93 seconds IncrementalBuild PENDING 0.25 seconds ScanBuild PASS 878.71 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 25 Mar 2025 17:32:30 -0400 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > Legacy experimental LL Privacy was not enabled by default but > CentralAddressResolution is which may cause problems with old > kernels were LL Privacy may not work as expected. > > Fixes: https://github.com/bluez/bluez/issues/1138 > > [...] Here is the summary with links: - [BlueZ,v1] main: Fix handling of legacy experimental LL Privacy https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=bbc1c2a7f06e You are awesome, thank you!
diff --git a/src/main.c b/src/main.c index 50346abbb4d1..6a682e9b921f 100644 --- a/src/main.c +++ b/src/main.c @@ -715,20 +715,11 @@ static bool match_experimental(const void *data, const void *match_data) bool btd_kernel_experimental_enabled(const char *uuid) { if (!btd_opts.kernel) - goto done; + return false; if (queue_find(btd_opts.kernel, match_experimental, uuid)) return true; -done: - /* For backward compatibility set LL Privacy as enabled if - * CentralAddressResolution has been set so old kernel LL Privacy is - * enabled. - */ - if (!strcmp(uuid, "15c0a148-c273-11ea-b3de-0242ac130004") && - btd_opts.defaults.le.addr_resolution) - return true; - return false; }
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Legacy experimental LL Privacy was not enabled by default but CentralAddressResolution is which may cause problems with old kernels were LL Privacy may not work as expected. Fixes: https://github.com/bluez/bluez/issues/1138 --- src/main.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)