| Message ID | 20250326-scsi-sync-on-write-v2-1-12ab05bd464b@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: ensure writes are flushed to disk | expand |
On 26/03/2025 13:24, Caleb Connolly wrote: > This clears the 6th byte of cmd twice rather than setting the 9th byte > to 0. Fix it. > > The only other command that sets the 9th byte is the 64-bit read, so > this likely never caused issues in practise. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > drivers/scsi/scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > index cd0b84c062252118d250b9305728e03f61736600..34ac47c03ab397ca999abf130d84ccbd3be4c419 100644 > --- a/drivers/scsi/scsi.c > +++ b/drivers/scsi/scsi.c > @@ -89,9 +89,9 @@ static void scsi_setup_read_ext(struct scsi_cmd *pccb, lbaint_t start, > pccb->cmd[5] = (unsigned char)start & 0xff; > pccb->cmd[6] = 0; > pccb->cmd[7] = (unsigned char)(blocks >> 8) & 0xff; > pccb->cmd[8] = (unsigned char)blocks & 0xff; > - pccb->cmd[6] = 0; > + pccb->cmd[9] = 0; > pccb->cmdlen = 10; > pccb->msgout[0] = SCSI_IDENTIFY; /* NOT USED */ > debug("scsi_setup_read_ext: cmd: %02X %02X startblk %02X%02X%02X%02X blccnt %02X%02X\n", > pccb->cmd[0], pccb->cmd[1], > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index cd0b84c062252118d250b9305728e03f61736600..34ac47c03ab397ca999abf130d84ccbd3be4c419 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -89,9 +89,9 @@ static void scsi_setup_read_ext(struct scsi_cmd *pccb, lbaint_t start, pccb->cmd[5] = (unsigned char)start & 0xff; pccb->cmd[6] = 0; pccb->cmd[7] = (unsigned char)(blocks >> 8) & 0xff; pccb->cmd[8] = (unsigned char)blocks & 0xff; - pccb->cmd[6] = 0; + pccb->cmd[9] = 0; pccb->cmdlen = 10; pccb->msgout[0] = SCSI_IDENTIFY; /* NOT USED */ debug("scsi_setup_read_ext: cmd: %02X %02X startblk %02X%02X%02X%02X blccnt %02X%02X\n", pccb->cmd[0], pccb->cmd[1],
This clears the 6th byte of cmd twice rather than setting the 9th byte to 0. Fix it. The only other command that sets the 9th byte is the 64-bit read, so this likely never caused issues in practise. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- drivers/scsi/scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)