| Message ID | 20250328083619.1262150-1-mstrozek@opensource.cirrus.com |
|---|---|
| State | New |
| Headers | show |
| Series | [alsa-ucm-conf,1/2] sof-soundwire: cs42l43: Drop headset mic from mic mute LED | expand |
On 28. 03. 25 9:36, Maciej Strozek wrote: > As per conversation in [1], let headsets be dropped from LED bindings. > Also remove turning off the mics on device disable since they are now > not needed. Actually, it's preferred to turn off the unused paths. I would keep the sequences. Jaroslav
W dniu pią, 28.03.2025 o godzinie 11∶41 +0100, użytkownik Jaroslav Kysela napisał: > On 28. 03. 25 9:36, Maciej Strozek wrote: > > Hardware volume control in cs42l43 can go up to +31.5dB which can > > cause audio > > degradation. For best results, keep the hardware volume set to 0dB > > and let > > software volume control the output. > > It's something which I dislike (software volume control). If there's > a > hardware limit, it should be added to the driver. Eventually, alsa- > lib plugins > may be extended to do this cropping using a configuration. Also, it > may be a > bug in pulseaudio/pipewire. The +0dB volumes should be handed with a > care. I agree this is not very elegant to leave it to soft volume, but until things are resolved elsewhere this is the best way to get best audio for most users? > > Jaroslav >
On 28. 03. 25 11:58, Maciej Strozek wrote: > W dniu pią, 28.03.2025 o godzinie 11∶41 +0100, użytkownik Jaroslav > Kysela napisał: >> On 28. 03. 25 9:36, Maciej Strozek wrote: >>> Hardware volume control in cs42l43 can go up to +31.5dB which can >>> cause audio >>> degradation. For best results, keep the hardware volume set to 0dB >>> and let >>> software volume control the output. >> >> It's something which I dislike (software volume control). If there's >> a >> hardware limit, it should be added to the driver. Eventually, alsa- >> lib plugins >> may be extended to do this cropping using a configuration. Also, it >> may be a >> bug in pulseaudio/pipewire. The +0dB volumes should be handed with a >> care. > > I agree this is not very elegant to leave it to soft volume, but until > things are resolved elsewhere this is the best way to get best audio > for most users? I don't see the pipewire upstream report. Please, make an report against pipewire to move discussion there and add the Link: tag to the comment. If you like to disable something just because the UCM application does not support a feature or misbehaves right now, use a new application variable like @SplitPCM - see [1]. A nice name may be '@OutMix>0dB' or so. Jaroslav [1] https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/common/pcm/split.conf
W dniu pon, 31.03.2025 o godzinie 15∶43 +0200, użytkownik Jaroslav Kysela napisał: > > I don't see the pipewire upstream report. Please, make an report > against > pipewire to move discussion there and add the Link: tag to the > comment. > > If you like to disable something just because the UCM application > does not > support a feature or misbehaves right now, use a new application > variable like > @SplitPCM - see [1]. A nice name may be '@OutMix>0dB' or so. > > Jaroslav > Thanks! Will have a look at those variables and submit something to github soon. Also will include the pipewire issue link which is [1] for reference. [1] https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/4622
diff --git a/ucm2/codecs/cs42l43/init.conf b/ucm2/codecs/cs42l43/init.conf index 0e987c21..c0fa863c 100644 --- a/ucm2/codecs/cs42l43/init.conf +++ b/ucm2/codecs/cs42l43/init.conf @@ -10,9 +10,3 @@ LibraryConfig.remap.Config { } } } - -BootSequence [ - cset "name='cs42l43 Decimator 1 Switch' 0" -] - -Macro [{ SetLED { LED="mic" Action="attach" CtlId="cs42l43 Decimator 1 Switch" } }] diff --git a/ucm2/sof-soundwire/cs42l43-dmic.conf b/ucm2/sof-soundwire/cs42l43-dmic.conf index 70ce40ff..b68a70d1 100644 --- a/ucm2/sof-soundwire/cs42l43-dmic.conf +++ b/ucm2/sof-soundwire/cs42l43-dmic.conf @@ -13,8 +13,6 @@ SectionDevice."Mic" { ] DisableSequence [ - cset "name='cs42l43 Decimator 3 Switch' 0" - cset "name='cs42l43 Decimator 4 Switch' 0" cset "name='cs42l43 DP1TX1 Input' 'None'" cset "name='cs42l43 DP1TX2 Input' 'None'" ] diff --git a/ucm2/sof-soundwire/cs42l43.conf b/ucm2/sof-soundwire/cs42l43.conf index 4b4e1187..51832126 100644 --- a/ucm2/sof-soundwire/cs42l43.conf +++ b/ucm2/sof-soundwire/cs42l43.conf @@ -33,7 +33,6 @@ SectionDevice."Headset" { ] DisableSequence [ - cset "name='cs42l43 Decimator 1 Switch' 0" cset "name='cs42l43 DP2TX1 Input' 'None'" cset "name='cs42l43 DP2TX2 Input' 'None'" ]
As per conversation in [1], let headsets be dropped from LED bindings. Also remove turning off the mics on device disable since they are now not needed. [1]: https://github.com/alsa-project/alsa-ucm-conf/pull/512 Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com> --- ucm2/codecs/cs42l43/init.conf | 6 ------ ucm2/sof-soundwire/cs42l43-dmic.conf | 2 -- ucm2/sof-soundwire/cs42l43.conf | 1 - 3 files changed, 9 deletions(-) -- 2.39.5