| Message ID | 20250328-s2mpg10-v2-30-b54dee33fb6b@linaro.org |
|---|---|
| State | New |
| Headers | show
Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com
[209.85.208.42])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0735235C17
for <linux-samsung-soc@vger.kernel.org>;
Fri, 28 Mar 2025 13:31:13 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.208.42
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1743168682; cv=none;
b=Bnx42cX0IJVHMUVAoRl6vbiUb//OmBHcNbeDaa1AmVMV7CogpQBdSV64HPgE9gfsj5AGIPTYG0Q8BHxXZSG2slwbWRotq9JVSATR5wWTPIJmn8/O6gMr4YzzCAKJIMjYDxID3fOUF3XArVvVguQ0GDEcyIbztpPCEsKJ00rbMjI=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1743168682; c=relaxed/simple;
bh=oM7nIChVy6AnX102peSIS6No2vZfRMNewLZjt/WfrE0=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
In-Reply-To:To:Cc;
b=LgoPaL+dJJJLIJOnjcQMOCCrTgm8r063ioVsuL912HctME85yr5o8dBWXHLralbmVxHi2pPSezsWRhFki9uQ89aglCh1ZmmHqs5rVyyQ9pPfUaOmVTJognqc/81OzYvBOM5f7gL9X3q8YJZc6qLgRlBEKOUhy+YRclVpY/H9S94=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org;
spf=pass smtp.mailfrom=linaro.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b=h/Dz7krH; arc=none smtp.client-ip=209.85.208.42
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="h/Dz7krH"
Received: by mail-ed1-f42.google.com with SMTP id
4fb4d7f45d1cf-5e535e6739bso3577080a12.1
for <linux-samsung-soc@vger.kernel.org>;
Fri, 28 Mar 2025 06:31:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1743168670; x=1743773470;
darn=vger.kernel.org;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:from:to:cc:subject:date:message-id
:reply-to;
bh=31t2yEGURbHN+dYzF9A6q02DZ3VBH6YOfFo8ts0pTFs=;
b=h/Dz7krHtN0w9o/IOClhkmZijx7OtzSMyotcInOQrxRodXDX+Qz2ndUVAlGCBevzKK
3BZfFMMOvjVJff1X2bNSDFui2vy0AjqY7aa0D2/3GW10OT34B4Li+LcS9t8d29mzC6QL
b5S0eRNeldL63/L+8Ui5WXARXi4KvIfr4Znlc5Uvp+JaP7t79hMWzsHvPKP2G4qn6O5/
DREiKF4FWVArUSTzB+K0wxm719HutQZU59Np6EpzhPlJfV8pjVD7XkwYseI+BzgxXpAp
+xnygv8a/P6u6yb5WauppZ2MQJn7UC5KyMi9ci6hlMJz2+MK+sNyCWKu8BVvinEDQezk
0L2A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743168670; x=1743773470;
h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
:mime-version:subject:date:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=31t2yEGURbHN+dYzF9A6q02DZ3VBH6YOfFo8ts0pTFs=;
b=YaJD7G3/JBMA46b+WSgXCVjvEEaHG2nhXQ1RwzNGNL6w8sIvMazO78/SwzL2xGT+fr
lcsnMX+vbwoPgUu6F2WPHHGDH8kzVrPTpDMNZBF24FWMi3LX6MaegpHXsr9fKAlLh1M4
L5Hkhu2N651a7cK/J72+koyGO55b+JRvYLTlIOdT49Iob0/L6Mi3wX2NOCZX5nNIipZ5
muP3YzsoMprgSRztG/WcsDoMeDU2WeIJQc0azVREo0eouEG036NPFtrOUiW/IIuiXX7M
Mt71LgLEKxw270qBrZeB8ticp+R0r3ByA8RS5RidPEIckSuQeGspjfOf3mRujdS3L6xQ
y/Zg==
X-Forwarded-Encrypted: i=1;
AJvYcCUiEnOx3KCg6EifcTrIdOazzxVaDTHbK+E2zlxyTjC2ZE/vTSeO6K+Jpj1f1FQvXrlYXmY4le01xX1JVGASrLuW8Q==@vger.kernel.org
X-Gm-Message-State: AOJu0Yw/aeerpY4UwPHrzYPCx5SiA5EW440D1bZgTUnLojG6ztxA72le
aEDlqoFmB2IVjD8aAsrGZM+ynKOCvF4VjzvF5AJFGRlCXlLRCcXWd9cj32qH3e0=
X-Gm-Gg: ASbGncv4uLtlpyGvAdRroEoJdZEX3clyR97d75FEEByT7W9yBUxp0V+zSn0eBx/XM+o
LS/dqKv2bQm3rygnh9nNQqCfO9PUg9sC3lvyuYiOZt8zF4Vc91j7f0bgQooQx1LnuLBRSxWmoY1
j5Wgq30FvkF7I3a94bE9XvjHa3ikacWNABoVtxZE+90tjLGzQKWmhezH4IdcWMtXb8bHotJl9mK
4tAVhCl6cvYtgQloR47avVpapmNVA2rqqpb7EgtDgggDjz9cfuQnUroFaJnFd7xdLJyBJ4/MaAX
xxHKKlWnlHauqez310cafdiQsdJZn+uNeuQ8GXqEphRjCTy5hvnVYs34HAxDh5F9jSTcEtnnYNH
wc92qybWs9/bC2BWyLPKnaBk59O9B
X-Google-Smtp-Source:
AGHT+IHYdNpE5Oaiy98m+ZWWJjpn0kB8pbikHk0ZcUltpSgeHSv0me+ylZHKLUVEOgvnZGzJh/notA==
X-Received: by 2002:a05:6402:518d:b0:5e7:b02b:6430 with SMTP id
4fb4d7f45d1cf-5ed8f3fd122mr6775177a12.23.1743168670150;
Fri, 28 Mar 2025 06:31:10 -0700 (PDT)
Received: from puffmais.c.googlers.com (8.239.204.35.bc.googleusercontent.com.
[35.204.239.8])
by smtp.gmail.com with ESMTPSA id
4fb4d7f45d1cf-5edc17e01f7sm1355284a12.79.2025.03.28.06.31.09
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 28 Mar 2025 06:31:09 -0700 (PDT)
From: =?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
Date: Fri, 28 Mar 2025 13:29:16 +0000
Subject: [PATCH v2 30/32] rtc: s5m: replace regmap_update_bits with
regmap_clear/set_bits
Precedence: bulk
X-Mailing-List: linux-samsung-soc@vger.kernel.org
List-Id: <linux-samsung-soc.vger.kernel.org>
List-Subscribe: <mailto:linux-samsung-soc+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-samsung-soc+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Message-Id: <20250328-s2mpg10-v2-30-b54dee33fb6b@linaro.org>
References: <20250328-s2mpg10-v2-0-b54dee33fb6b@linaro.org>
In-Reply-To: <20250328-s2mpg10-v2-0-b54dee33fb6b@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>, kernel-team@android.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
=?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
X-Mailer: b4 0.14.2
|
| Series |
Samsung S2MPG10 PMIC MFD-based drivers
|
expand
|
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index e8e442c503064eb4e570af5bf7dcff6bfa7f4656..fb65a8e439d72d9070751c00f5826a403ac0b416 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -338,8 +338,8 @@ static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) /* On S2MPS13 the AUDR is not auto-cleared */ if (info->device_type == S2MPS13X) - regmap_update_bits(info->regmap, info->regs->udr_update, - S2MPS13_RTC_AUDR_MASK, 0); + regmap_clear_bits(info->regmap, info->regs->udr_update, + S2MPS13_RTC_AUDR_MASK); return ret; } @@ -351,10 +351,8 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm) int ret; if (info->regs->read_time_udr_mask) { - ret = regmap_update_bits(info->regmap, - info->regs->udr_update, - info->regs->read_time_udr_mask, - info->regs->read_time_udr_mask); + ret = regmap_set_bits(info->regmap, info->regs->udr_update, + info->regs->read_time_udr_mask); if (ret) { dev_err(dev, "Failed to prepare registers for time reading: %d\n",
The regmap_clear_bits() and regmap_set_bits() helper macros state the intention a bit more obviously. Use those. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- drivers/rtc/rtc-s5m.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)