| Message ID | 20250329172237.61874-1-markus@notsyncing.net |
|---|---|
| State | New |
| Headers | show |
| Series | Input: fsia6b: Increase size of phys to hold full name | expand |
Hi, I sent a patch 2 weeks ago [1] and haven't heard back yet. The same happened for another patch I submitted at the end of last year [2], where in the meantime the patch of someone else (doing exactly the same) got merged. Therefore I have to ask: Am I doing something wrong? Is there a preferred way to submit patches for this subsystem that I'm missing (like Gitlab PRs or something)? I'm happy to change my workflow if it helps you. Thank you, Markus [1]: https://patchwork.kernel.org/project/linux-input/patch/20250329172237.61874-1-markus@notsyncing.net/ [2]: https://patchwork.kernel.org/project/linux-input/patch/20241223153453.12924-3-markus@notsyncing.net/
Hi, just following up again since I haven't heard back at all about my patch from late March [1]. It's OK if you'd like this issue solved in a completely different way, or not at all (I saw some controversy about this topic on the mailing list), just let me know so that I can act accordingly. Or, if more time is needed, a quick "we're still investigating how to handle these cases" is also appreciated. Thanks! Markus [1]: https://patchwork.kernel.org/project/linux-input/patch/20250329172237.61874-1-markus@notsyncing.net/
Hi Markus, On Fri, Apr 11, 2025 at 07:38:12PM +0200, Markus Koch wrote: > Hi, > > I sent a patch 2 weeks ago [1] and haven't heard back yet. The same > happened for another patch I submitted at the end of last year [2], > where in the meantime the patch of someone else (doing exactly the > same) got merged. Therefore I have to ask: > > Am I doing something wrong? Is there a preferred way to submit patches > for this subsystem that I'm missing (like Gitlab PRs or something)? > I'm happy to change my workflow if it helps you. > No, you are not doing anything wrong, the issue is on my side. I have quite a bit of backlog and so often go through my mailbox in LIFO order. This means that I might sometimes merge a "newer" patch instead of picking up the first one. As far as extending "phys" I indeed do not want to do that because it is perfectly fine to have truncated phys (or we can extend it when we encounter a device that actually needs it vs doing it just to appease the check). I think switching from snprintf() to scnprintf() will shut off the warning. Could you please let me know if it does it from you? Thanks.
diff --git a/drivers/input/joystick/fsia6b.c b/drivers/input/joystick/fsia6b.c index 76ffdec5c183..ef1a7a3a867c 100644 --- a/drivers/input/joystick/fsia6b.c +++ b/drivers/input/joystick/fsia6b.c @@ -56,7 +56,7 @@ struct fsia6b { struct input_dev *dev; struct ibus_packet packet; - char phys[32]; + char phys[sizeof_field(struct serio, phys)+7]; }; static irqreturn_t fsia6b_serio_irq(struct serio *serio,
The driver appends "/input0" to the phys name of the serio device. This commit ensures that there is enough space in the variable to do so. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202501020303.1WtxWWTu-lkp@intel.com/ Signed-off-by: Markus Koch <markus@notsyncing.net> --- drivers/input/joystick/fsia6b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)