| Message ID | 20250401080337.2187400-1-nichen@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | serial: lantiq: Remove unnecessary print function dev_err() | expand |
On 4/1/2025 1:33 PM, Chen Ni wrote: > Function dev_err() is redundant because platform_get_irq() > already prints an error. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> > --- > drivers/tty/serial/lantiq.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c > index 58a3ab030d67..62cd9e0bb377 100644 > --- a/drivers/tty/serial/lantiq.c > +++ b/drivers/tty/serial/lantiq.c > @@ -773,10 +773,8 @@ static int fetch_irq_intel(struct device *dev, struct ltq_uart_port *ltq_port) > int ret; > > ret = platform_get_irq(to_platform_device(dev), 0); > - if (ret < 0) { > - dev_err(dev, "failed to fetch IRQ for serial port\n"); > + if (ret < 0) > return ret; > - } > ltq_port->common_irq = ret; > port->irq = ret; >
diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index 58a3ab030d67..62cd9e0bb377 100644 --- a/drivers/tty/serial/lantiq.c +++ b/drivers/tty/serial/lantiq.c @@ -773,10 +773,8 @@ static int fetch_irq_intel(struct device *dev, struct ltq_uart_port *ltq_port) int ret; ret = platform_get_irq(to_platform_device(dev), 0); - if (ret < 0) { - dev_err(dev, "failed to fetch IRQ for serial port\n"); + if (ret < 0) return ret; - } ltq_port->common_irq = ret; port->irq = ret;
Function dev_err() is redundant because platform_get_irq() already prints an error. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/tty/serial/lantiq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)