diff mbox series

[v2,2/4] gpio: deprecate devm_gpiod_unhinge()

Message ID 20250401-gpio-todo-remove-nonexclusive-v2-2-7c1380797b0d@linaro.org
State New
Headers show
Series gpio: deprecate and track the removal of GPIO workarounds for regulators | expand

Commit Message

Bartosz Golaszewski April 1, 2025, 12:46 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This function was introduced as a workaround for an issue with resource
ownership in the regulator subsystem. Rather than passing the ownership
of a GPIO, we should make the regulator core be able to deal with
resources it didn't request. Deprecate this function so that we don't
get more users in the tree.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpiolib-devres.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Linus Walleij April 15, 2025, 7:55 a.m. UTC | #1 
On Tue, Apr 1, 2025 at 2:46 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This function was introduced as a workaround for an issue with resource
> ownership in the regulator subsystem. Rather than passing the ownership
> of a GPIO, we should make the regulator core be able to deal with
> resources it didn't request. Deprecate this function so that we don't
> get more users in the tree.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpio/gpiolib-devres.c b/drivers/gpio/gpiolib-devres.c
index 08205f355ceb..120d1ec5af3b 100644
--- a/drivers/gpio/gpiolib-devres.c
+++ b/drivers/gpio/gpiolib-devres.c
@@ -317,11 +317,15 @@  EXPORT_SYMBOL_GPL(devm_gpiod_put);
  * @dev:	GPIO consumer
  * @desc:	GPIO descriptor to remove resource management from
  *
+ * *DEPRECATED*
+ * This function should not be used. It's been provided as a workaround for
+ * resource ownership issues in the regulator framework and should be replaced
+ * with a better solution.
+ *
  * Remove resource management from a GPIO descriptor. This is needed when
  * you want to hand over lifecycle management of a descriptor to another
  * mechanism.
  */
-
 void devm_gpiod_unhinge(struct device *dev, struct gpio_desc *desc)
 {
 	int ret;