| Message ID | 20250402154942.3645283-2-daniel.lezcano@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer | expand |
On 02/04/2025 17:49, Daniel Lezcano wrote: > Describe the Software Watchdog Timer available on the S32G platforms. > > Cc: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > Cc: Thomas Fossati <thomas.fossati@linaro.org> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 02/04/2025 17:56, Krzysztof Kozlowski wrote: > On 02/04/2025 17:49, Daniel Lezcano wrote: >> Describe the Software Watchdog Timer available on the S32G platforms. >> >> Cc: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> >> Cc: Thomas Fossati <thomas.fossati@linaro.org> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof I ran the make dt_binding_check but inadvertently removed the "oneOf:" after :/
On 03/04/2025 01:01, Daniel Lezcano wrote: > On 02/04/2025 17:56, Krzysztof Kozlowski wrote: >> On 02/04/2025 17:49, Daniel Lezcano wrote: >>> Describe the Software Watchdog Timer available on the S32G platforms. >>> >>> Cc: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> >>> Cc: Thomas Fossati <thomas.fossati@linaro.org> >>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Best regards, >> Krzysztof > > I ran the make dt_binding_check but inadvertently removed the "oneOf:" > after :/ Other errors were also not fixed even though you got report on them on 29th of March. Best regards, Krzysztof
On 03/04/2025 16:16, Krzysztof Kozlowski wrote: > On 03/04/2025 01:01, Daniel Lezcano wrote: >> On 02/04/2025 17:56, Krzysztof Kozlowski wrote: >>> On 02/04/2025 17:49, Daniel Lezcano wrote: >>>> Describe the Software Watchdog Timer available on the S32G platforms. >>>> >>>> Cc: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> >>>> Cc: Thomas Fossati <thomas.fossati@linaro.org> >>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> Best regards, >>> Krzysztof >> >> I ran the make dt_binding_check but inadvertently removed the "oneOf:" >> after :/ > Other errors were also not fixed even though you got report on them on > 29th of March. Which ones ? All errors were coming from the oneOf removal, after re-adding it they are all gone
On 03/04/2025 17:35, Krzysztof Kozlowski wrote: > On 03/04/2025 17:33, Daniel Lezcano wrote: >> On 03/04/2025 16:16, Krzysztof Kozlowski wrote: >>> On 03/04/2025 01:01, Daniel Lezcano wrote: >>>> On 02/04/2025 17:56, Krzysztof Kozlowski wrote: >>>>> On 02/04/2025 17:49, Daniel Lezcano wrote: >>>>>> Describe the Software Watchdog Timer available on the S32G platforms. >>>>>> >>>>>> Cc: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> >>>>>> Cc: Thomas Fossati <thomas.fossati@linaro.org> >>>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> >>>> I ran the make dt_binding_check but inadvertently removed the "oneOf:" >>>> after :/ >>> Other errors were also not fixed even though you got report on them on >>> 29th of March. >> >> Which ones ? >> >> All errors were coming from the oneOf removal, after re-adding it they >> are all gone > > > The same as from previous patchset - wrong unit address, maybe more. Indeed, my parser was not up-to-date and did not reported the error. Thanks for pointing this out -- Daniel
diff --git a/Documentation/devicetree/bindings/watchdog/nxp,s32g2-swt.yaml b/Documentation/devicetree/bindings/watchdog/nxp,s32g2-swt.yaml new file mode 100644 index 000000000000..d5f2513c4e8f --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/nxp,s32g2-swt.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/nxp,s32g2-swt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP Software Watchdog Timer (SWT) + +maintainers: + - Daniel Lezcano <daniel.lezcano@kernel.org> + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + - const: nxp,s32g2-swt + - items: + - const: nxp,s32g3-swt + - const: nxp,s32g2-swt + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - clocks + +unevaluatedProperties: false + +examples: + - | + watchdog@0x40100000 { + compatible = "nxp,s32g2-swt"; + reg = <0x40100000 0x1000>; + clocks = <&clks 0x3a>; + timeout-sec = <10>; + };
Describe the Software Watchdog Timer available on the S32G platforms. Cc: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> Cc: Thomas Fossati <thomas.fossati@linaro.org> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- .../bindings/watchdog/nxp,s32g2-swt.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/nxp,s32g2-swt.yaml