diff mbox series

[RFC,PATCH-for-10.1,26/39] system/hvf: Avoid including 'cpu.h'

Message ID 20250403235821.9909-27-philmd@linaro.org
State Superseded
Headers show
Series single-binary: Make hw/arm/ common | expand

Commit Message

Philippe Mathieu-Daudé April 3, 2025, 11:58 p.m. UTC 
"system/hvf.h" doesn't need to include a full "cpu.h",
only "exec/vaddr.h" and "qemu/queue.h" are required.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/system/hvf.h     | 3 ++-
 include/system/hvf_int.h | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé May 6, 2025, 2:14 p.m. UTC | #1 
ping?

On 4/4/25 01:58, Philippe Mathieu-Daudé wrote:
> "system/hvf.h" doesn't need to include a full "cpu.h",
> only "exec/vaddr.h" and "qemu/queue.h" are required.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/system/hvf.h     | 3 ++-
>   include/system/hvf_int.h | 2 ++
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/system/hvf.h b/include/system/hvf.h
> index 730f927f034..d50049e1a1a 100644
> --- a/include/system/hvf.h
> +++ b/include/system/hvf.h
> @@ -14,10 +14,11 @@
>   #define HVF_H
>   
>   #include "qemu/accel.h"
> +#include "qemu/queue.h"
> +#include "exec/vaddr.h"
>   #include "qom/object.h"
>   
>   #ifdef COMPILING_PER_TARGET
> -#include "cpu.h"
>   
>   #ifdef CONFIG_HVF
>   extern bool hvf_allowed;
> diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h
> index 42ae18433f0..8c8b84012d9 100644
> --- a/include/system/hvf_int.h
> +++ b/include/system/hvf_int.h
> @@ -11,6 +11,8 @@
>   #ifndef HVF_INT_H
>   #define HVF_INT_H
>   
> +#include "qemu/queue.h"
> +
>   #ifdef __aarch64__
>   #include <Hypervisor/Hypervisor.h>
>   typedef hv_vcpu_t hvf_vcpuid;
Pierrick Bouvier May 6, 2025, 3 p.m. UTC | #2 
On 5/6/25 7:14 AM, Philippe Mathieu-Daudé wrote:
> ping?
> 
> On 4/4/25 01:58, Philippe Mathieu-Daudé wrote:
>> "system/hvf.h" doesn't need to include a full "cpu.h",
>> only "exec/vaddr.h" and "qemu/queue.h" are required.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>    include/system/hvf.h     | 3 ++-
>>    include/system/hvf_int.h | 2 ++
>>    2 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff mbox series

Patch

diff --git a/include/system/hvf.h b/include/system/hvf.h
index 730f927f034..d50049e1a1a 100644
--- a/include/system/hvf.h
+++ b/include/system/hvf.h
@@ -14,10 +14,11 @@ 
 #define HVF_H
 
 #include "qemu/accel.h"
+#include "qemu/queue.h"
+#include "exec/vaddr.h"
 #include "qom/object.h"
 
 #ifdef COMPILING_PER_TARGET
-#include "cpu.h"
 
 #ifdef CONFIG_HVF
 extern bool hvf_allowed;
diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h
index 42ae18433f0..8c8b84012d9 100644
--- a/include/system/hvf_int.h
+++ b/include/system/hvf_int.h
@@ -11,6 +11,8 @@ 
 #ifndef HVF_INT_H
 #define HVF_INT_H
 
+#include "qemu/queue.h"
+
 #ifdef __aarch64__
 #include <Hypervisor/Hypervisor.h>
 typedef hv_vcpu_t hvf_vcpuid;