diff mbox series

[v2] obex: Send response to client for Abort request

Message ID 20250410062057.1845550-1-quic_amisjain@quicinc.com
State Superseded
Headers show
Series [v2] obex: Send response to client for Abort request | expand

Commit Message

Amisha Jain April 10, 2025, 6:20 a.m. UTC 
Incase of ongoing transfer, If the client sends Abort request, Server is not
sending any response back.

Ideally it should send OK or Success reponse code for the abort command.

This is required in PTS testing for passing below testcases -
1) OPP/SR/OPH/BV-27-I
To verify that a server can respond to an ABORT from the client during an OBEX operation.
2)FTP/SR/OTR/BV-02-C
To verify that the pushed file is aborted normally.
3)PBAP/PSE/PDF/BV-06-I
Verify that the PCE can abort a Phone Book object download from the PSE.
4)PBAP/PSE/PBF/BV-03-I
Verify that the PCE can abort a vCard-listing object download from the PSE.

---
 obexd/src/obex.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

bluez.test.bot@gmail.com April 10, 2025, 7:41 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=951852

---Test result---

Test Summary:
CheckPatch                    PENDING   0.42 seconds
GitLint                       PENDING   1.77 seconds
BuildEll                      PASS      20.72 seconds
BluezMake                     PASS      2628.98 seconds
MakeCheck                     PASS      20.40 seconds
MakeDistcheck                 PASS      198.21 seconds
CheckValgrind                 PASS      274.92 seconds
CheckSmatch                   PASS      302.25 seconds
bluezmakeextell               PASS      128.34 seconds
IncrementalBuild              PENDING   0.33 seconds
ScanBuild                     PASS      898.88 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/obexd/src/obex.c b/obexd/src/obex.c
index 370bfac9e..0330d5a7c 100644
--- a/obexd/src/obex.c
+++ b/obexd/src/obex.c
@@ -389,6 +389,8 @@  static void transfer_complete(GObex *obex, GError *err, gpointer user_data)
 
 	if (err != NULL) {
 		error("transfer failed: %s\n", err->message);
+		if (strcmp(err->message, "Request was aborted") == 0)
+			os_set_response(os, 0);
 		goto reset;
 	}