| Message ID | 20250416-wmt-updates-v1-12-f9af689cdfc2@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: vt8500: DT bindings and dts updates | expand |
On 16/04/2025 10:21, Alexey Charkov wrote: > diff --git a/arch/arm/boot/dts/vt8500/Makefile b/arch/arm/boot/dts/vt8500/Makefile > index 255f4403af91c1d6a22416ab694b8eab44bf98a2..c5a2e57d53af4babe40fe2d79b2f8d9c1ae1b8db 100644 > --- a/arch/arm/boot/dts/vt8500/Makefile > +++ b/arch/arm/boot/dts/vt8500/Makefile > @@ -4,4 +4,5 @@ dtb-$(CONFIG_ARCH_VT8500) += \ > wm8505-ref.dtb \ > wm8650-mid.dtb \ > wm8750-apc8750.dtb \ > - wm8850-w70v2.dtb > + wm8850-w70v2.dtb \ > + wm8950a-apc-rock.dtb > diff --git a/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts b/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts > new file mode 100644 > index 0000000000000000000000000000000000000000..58b3c8deb4f20ae072bf1381f1dfa5e5adeb414a > --- /dev/null > +++ b/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later Odd license, we don't do GPL v4 in the kernel. We do however dual license for bindings and DTS. Why choosing such license? Did you take the code from somewhere? Best regards, Krzysztof
On Thu, Apr 17, 2025 at 9:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 16/04/2025 10:21, Alexey Charkov wrote: > > diff --git a/arch/arm/boot/dts/vt8500/Makefile b/arch/arm/boot/dts/vt8500/Makefile > > index 255f4403af91c1d6a22416ab694b8eab44bf98a2..c5a2e57d53af4babe40fe2d79b2f8d9c1ae1b8db 100644 > > --- a/arch/arm/boot/dts/vt8500/Makefile > > +++ b/arch/arm/boot/dts/vt8500/Makefile > > @@ -4,4 +4,5 @@ dtb-$(CONFIG_ARCH_VT8500) += \ > > wm8505-ref.dtb \ > > wm8650-mid.dtb \ > > wm8750-apc8750.dtb \ > > - wm8850-w70v2.dtb > > + wm8850-w70v2.dtb \ > > + wm8950a-apc-rock.dtb > > diff --git a/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts b/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts > > new file mode 100644 > > index 0000000000000000000000000000000000000000..58b3c8deb4f20ae072bf1381f1dfa5e5adeb414a > > --- /dev/null > > +++ b/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts > > @@ -0,0 +1,21 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > Odd license, we don't do GPL v4 in the kernel. We do however dual > license for bindings and DTS. Why choosing such license? Did you take > the code from somewhere? I picked the license identifier of the wm8850.dtsi include, which defines most of the functionality for this board. No preference from my side, and happy to use whichever license is common practice for DTS, but I'm simply not sure how differently licensed files and includes combine together - thus the conservative choice to stick to what's already there. The original .dtsi was written by Tony Prisk, not me. Best regards, Alexey
On 17/04/2025 08:01, Alexey Charkov wrote: >>> diff --git a/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts b/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts >>> new file mode 100644 >>> index 0000000000000000000000000000000000000000..58b3c8deb4f20ae072bf1381f1dfa5e5adeb414a >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts >>> @@ -0,0 +1,21 @@ >>> +// SPDX-License-Identifier: GPL-2.0-or-later >> >> >> Odd license, we don't do GPL v4 in the kernel. We do however dual >> license for bindings and DTS. Why choosing such license? Did you take >> the code from somewhere? > > I picked the license identifier of the wm8850.dtsi include, which > defines most of the functionality for this board. No preference from > my side, and happy to use whichever license is common practice for > DTS, but I'm simply not sure how differently licensed files and > includes combine together - thus the conservative choice to stick to > what's already there. The original .dtsi was written by Tony Prisk, > not me. OK, that's fine. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/vt8500/Makefile b/arch/arm/boot/dts/vt8500/Makefile index 255f4403af91c1d6a22416ab694b8eab44bf98a2..c5a2e57d53af4babe40fe2d79b2f8d9c1ae1b8db 100644 --- a/arch/arm/boot/dts/vt8500/Makefile +++ b/arch/arm/boot/dts/vt8500/Makefile @@ -4,4 +4,5 @@ dtb-$(CONFIG_ARCH_VT8500) += \ wm8505-ref.dtb \ wm8650-mid.dtb \ wm8750-apc8750.dtb \ - wm8850-w70v2.dtb + wm8850-w70v2.dtb \ + wm8950a-apc-rock.dtb diff --git a/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts b/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts new file mode 100644 index 0000000000000000000000000000000000000000..58b3c8deb4f20ae072bf1381f1dfa5e5adeb414a --- /dev/null +++ b/arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (C) 2025 Alexey Charkov <alchark@gmail.com> + */ + +/dts-v1/; +/include/ "wm8950.dtsi" + +/ { + model = "VIA APC Rock"; + compatible = "via,apc-rock", "wm,wm8950"; + + memory@0 { + device_type = "memory"; + reg = <0x0 0x20000000>; + }; +}; + +&uart0 { + status = "okay"; +}; diff --git a/arch/arm/boot/dts/vt8500/wm8950.dtsi b/arch/arm/boot/dts/vt8500/wm8950.dtsi new file mode 100644 index 0000000000000000000000000000000000000000..31fba05d3c3e70b21a64d08b5cdf645102a1faf3 --- /dev/null +++ b/arch/arm/boot/dts/vt8500/wm8950.dtsi @@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (C) 2025 Alexey Charkov <alchark@gmail.com> + */ + +/* No differences have been discovered vs. WM8850, but chip markings differ */ +/include/ "wm8850.dtsi" + +/ { + compatible = "wm,wm8950"; +};
APC Rock is a development board based on WonderMedia WM8590 released around 2013. Paper is the same board, but with VGA port unpopulated and shipped with a recycled cardboard case Its hardware includes: * Single-core Cortex-A9 CPU at 800 MHz * 512MB DDR3 RAM * 4GB NAND flash * 8MB SPI NOR flash * ARM Mali-400 GPU * HDMI output (type A) capable of 1080p output * VGA output (on Rock, but not on Paper) * 2x USB 2.0 type A * 1x USB 2.0 OTG (microUSB connector) * microSD slot * 10/100M Ethernet * Combined headphones/mic via 3.5mm jack connector * Half-height miniPCIe slot (with only USB 2.0 signals) Signed-off-by: Alexey Charkov <alchark@gmail.com> --- arch/arm/boot/dts/vt8500/Makefile | 3 ++- arch/arm/boot/dts/vt8500/wm8950-apc-rock.dts | 21 +++++++++++++++++++++ arch/arm/boot/dts/vt8500/wm8950.dtsi | 11 +++++++++++ 3 files changed, 34 insertions(+), 1 deletion(-)