| Message ID | 20250425-miix-630-venus-v2-1-cdfca385a0c8@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] arm64: dts: qcom: msm8998-lenovo-miix-630: add Venus node | expand |
On Fri, Apr 25, 2025 at 12:28 PM Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote: > > Enable Venus on Lenovo Miix 630 and specify corresponding firmware file. I'm curious, how did this get validated? I didn't think there was enough infrastructure enabled on this platform to check that the lights were even on on in Venus. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > Changes in v2: > - Rebasde on top of linux-next > - Link to v1: https://lore.kernel.org/r/20250408-miix-630-venus-v1-1-771c330ee279@oss.qualcomm.com > --- > arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > index f160ba562b0af505bdc1357731f75a394b5eeeeb..c11b972771c3881a57ba5a4dfbdcea487da7c6f1 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > +++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts > @@ -100,6 +100,12 @@ i2c5_hid_active: i2c5-hid-active-state { > }; > }; > > +&venus { > + firmware-name = "qcom/msm8998/LENOVO/81F1/qcvss8998.mbn"; > + > + status = "okay"; > +}; > + > &wifi { > qcom,calibration-variant = "Lenovo_Miix630"; > }; > > --- > base-commit: 6ac908f24cd7ddae52c496bbc888e97ee7b033ac > change-id: 20250408-miix-630-venus-7a0b4f1f3788 > > Best regards, > -- > Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > >
On Mon, Apr 28, 2025 at 09:40:52AM -0600, Jeffrey Hugo wrote: > On Fri, Apr 25, 2025 at 12:28 PM Dmitry Baryshkov > <dmitry.baryshkov@oss.qualcomm.com> wrote: > > > > Enable Venus on Lenovo Miix 630 and specify corresponding firmware file. > > I'm curious, how did this get validated? I didn't think there was > enough infrastructure enabled on this platform to check that the > lights were even on on in Venus. I must admit, I basically checked that the firmware starts up. Marc Gonzalez worked on enablement of Venus on MSM8998 (on the freebox), so I didn't perform a thorough check. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > --- > > Changes in v2: > > - Rebasde on top of linux-next > > - Link to v1: https://lore.kernel.org/r/20250408-miix-630-venus-v1-1-771c330ee279@oss.qualcomm.com > > --- > > arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts | 6 ++++++ > > 1 file changed, 6 insertions(+) > >
On Mon, Apr 28, 2025 at 10:21 AM Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote: > > On Mon, Apr 28, 2025 at 09:40:52AM -0600, Jeffrey Hugo wrote: > > On Fri, Apr 25, 2025 at 12:28 PM Dmitry Baryshkov > > <dmitry.baryshkov@oss.qualcomm.com> wrote: > > > > > > Enable Venus on Lenovo Miix 630 and specify corresponding firmware file. > > > > I'm curious, how did this get validated? I didn't think there was > > enough infrastructure enabled on this platform to check that the > > lights were even on on in Venus. > > I must admit, I basically checked that the firmware starts up. Marc > Gonzalez worked on enablement of Venus on MSM8998 (on the freebox), so I > didn't perform a thorough check. If you got the FW starting up, that is farther than I expected. I must be wrong about the capabilities then. The DT node looks right to me. Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> > > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > > --- > > > Changes in v2: > > > - Rebasde on top of linux-next > > > - Link to v1: https://lore.kernel.org/r/20250408-miix-630-venus-v1-1-771c330ee279@oss.qualcomm.com > > > --- > > > arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > -- > With best wishes > Dmitry
On 4/28/25 7:48 PM, Jeffrey Hugo wrote: > On Mon, Apr 28, 2025 at 10:21 AM Dmitry Baryshkov > <dmitry.baryshkov@oss.qualcomm.com> wrote: >> >> On Mon, Apr 28, 2025 at 09:40:52AM -0600, Jeffrey Hugo wrote: >>> On Fri, Apr 25, 2025 at 12:28 PM Dmitry Baryshkov >>> <dmitry.baryshkov@oss.qualcomm.com> wrote: >>>> >>>> Enable Venus on Lenovo Miix 630 and specify corresponding firmware file. >>> >>> I'm curious, how did this get validated? I didn't think there was >>> enough infrastructure enabled on this platform to check that the >>> lights were even on on in Venus. >> >> I must admit, I basically checked that the firmware starts up. Marc >> Gonzalez worked on enablement of Venus on MSM8998 (on the freebox), so I >> didn't perform a thorough check. > > If you got the FW starting up, that is farther than I expected. I > must be wrong about the capabilities then. > The DT node looks right to me. If PIL accepts it, it's basically good to go Konrad
On Fri, 25 Apr 2025 21:26:13 +0300, Dmitry Baryshkov wrote: > Enable Venus on Lenovo Miix 630 and specify corresponding firmware file. > > Applied, thanks! [1/1] arm64: dts: qcom: msm8998-lenovo-miix-630: add Venus node commit: 25f185524c4722b2c18e2746c7c4aeb2107d571f Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts index f160ba562b0af505bdc1357731f75a394b5eeeeb..c11b972771c3881a57ba5a4dfbdcea487da7c6f1 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts +++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts @@ -100,6 +100,12 @@ i2c5_hid_active: i2c5-hid-active-state { }; }; +&venus { + firmware-name = "qcom/msm8998/LENOVO/81F1/qcvss8998.mbn"; + + status = "okay"; +}; + &wifi { qcom,calibration-variant = "Lenovo_Miix630"; };