| Message ID | 20250425010605epcms2p67e89b351398832fe0fd547404d3afc65@epcms2p6 |
|---|---|
| State | New |
| Headers | show |
| Series | ufs: core: Remove redundant query_complete trace | expand |
On 4/24/25 10:38 PM, Avri Altman wrote: > Fixes: 71aabb747d5f ("scsi: ufs: core: Reuse exec_dev_cmd") > Reviewed-by: Avri Altman <avri.altman@sandisk.com> With the Fixes: tag added: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On Fri, 2025-04-25 at 10:06 +0900, Keoseong Park wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > The query_complete trace was not removed after ufshcd_issue_dev_cmd() > was called from the bsg path, resulting in duplicate output. > > Below is an example of the trace: > > ufs-utils-773 [000] ..... 218.176933: ufshcd_upiu: query_send: > 0000:00:04.0: HDR:16 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 > 00 00 00 00 00 00 00 00 00 00 00 00 00 > ufs-utils-773 [000] ..... 218.177145: ufshcd_upiu: > query_complete: 0000:00:04.0: HDR:36 00 00 1f 00 01 00 00 00 00 00 > 00, OSF:03 07 00 00 00 00 00 00 00 00 00 08 00 00 00 00 > ufs-utils-773 [000] ..... 218.177146: ufshcd_upiu: > query_complete: 0000:00:04.0: HDR:36 00 00 1f 00 01 00 00 00 00 00 > 00, OSF:03 07 00 00 00 00 00 00 00 00 00 08 00 00 00 00 > > This commit removes the redundant trace call in the bsg path, > preventing > duplication. > > Signed-off-by: Keoseong Park <keosung.park@samsung.com> Reviewed-by: Peter Wang <peter.wang@mediatek.com>
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index be65fc4b5ccd..c78c7ad4e393 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -7271,8 +7271,6 @@ static int ufshcd_issue_devman_upiu_cmd(struct ufs_hba *hba, err = -EINVAL; } } - ufshcd_add_query_upiu_trace(hba, err ? UFS_QUERY_ERR : UFS_QUERY_COMP, - (struct utp_upiu_req *)lrbp->ucd_rsp_ptr); return err; }
The query_complete trace was not removed after ufshcd_issue_dev_cmd() was called from the bsg path, resulting in duplicate output. Below is an example of the trace: ufs-utils-773 [000] ..... 218.176933: ufshcd_upiu: query_send: 0000:00:04.0: HDR:16 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ufs-utils-773 [000] ..... 218.177145: ufshcd_upiu: query_complete: 0000:00:04.0: HDR:36 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00 00 00 00 00 00 00 08 00 00 00 00 ufs-utils-773 [000] ..... 218.177146: ufshcd_upiu: query_complete: 0000:00:04.0: HDR:36 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00 00 00 00 00 00 00 08 00 00 00 00 This commit removes the redundant trace call in the bsg path, preventing duplication. Signed-off-by: Keoseong Park <keosung.park@samsung.com> --- drivers/ufs/core/ufshcd.c | 2 -- 1 file changed, 2 deletions(-)