| Message ID | 20250429-ov9282-flash-strobe-v3-9-2105ce179952@linux.dev |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Hi Sakari, thanks for your comment! On Wed, Apr 30, 2025 at 08:39:43AM +0000, Sakari Ailus wrote: > Hi Richard, > > On Tue, Apr 29, 2025 at 02:59:14PM +0200, Richard Leitner wrote: > > Add read-only V4L2_CID_FLASH_STROBE_SOURCE control. Its value is fixed > > to V4L2_FLASH_STROBE_SOURCE_EXTERNAL as the camera sensor triggers the > > strobe based on its register settings. > > > > Signed-off-by: Richard Leitner <richard.leitner@linux.dev> > > --- > > drivers/media/i2c/ov9282.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c > > index 5ddbfc51586111fbd2e17b739fb3d28bfb0aee1e..34ea903a18dadeeebd497a4a8858abf12b598717 100644 > > --- a/drivers/media/i2c/ov9282.c > > +++ b/drivers/media/i2c/ov9282.c > > @@ -1367,6 +1367,7 @@ static int ov9282_init_controls(struct ov9282 *ov9282) > > struct v4l2_ctrl_handler *ctrl_hdlr = &ov9282->ctrl_handler; > > const struct ov9282_mode *mode = ov9282->cur_mode; > > struct v4l2_fwnode_device_properties props; > > + struct v4l2_ctrl *ctrl; > > u32 hblank_min; > > u32 lpfr; > > int ret; > > @@ -1446,6 +1447,13 @@ static int ov9282_init_controls(struct ov9282 *ov9282) > > v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_DURATION, > > 0, 13900, 1, 8); > > > > + ctrl = v4l2_ctrl_new_std_menu(ctrl_hdlr, &ov9282_ctrl_ops, > > + V4L2_CID_FLASH_STROBE_SOURCE, > > + V4L2_FLASH_STROBE_SOURCE_EXTERNAL, > > + ~(1 << V4L2_FLASH_STROBE_SOURCE_EXTERNAL), > > + V4L2_FLASH_STROBE_SOURCE_EXTERNAL); > > + ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY; > > Note that v4l2_ctrl_new_std_menu() may return NULL. Good catch. Thanks! Will add a check in v4. > > > + > > ret = v4l2_fwnode_device_parse(ov9282->dev, &props); > > if (!ret) { > > /* Failure sets ctrl_hdlr->error, which we check afterwards anyway */ > > > > -- > Sakari Ailus regards;rl
diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index 5ddbfc51586111fbd2e17b739fb3d28bfb0aee1e..34ea903a18dadeeebd497a4a8858abf12b598717 100644 --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -1367,6 +1367,7 @@ static int ov9282_init_controls(struct ov9282 *ov9282) struct v4l2_ctrl_handler *ctrl_hdlr = &ov9282->ctrl_handler; const struct ov9282_mode *mode = ov9282->cur_mode; struct v4l2_fwnode_device_properties props; + struct v4l2_ctrl *ctrl; u32 hblank_min; u32 lpfr; int ret; @@ -1446,6 +1447,13 @@ static int ov9282_init_controls(struct ov9282 *ov9282) v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_DURATION, 0, 13900, 1, 8); + ctrl = v4l2_ctrl_new_std_menu(ctrl_hdlr, &ov9282_ctrl_ops, + V4L2_CID_FLASH_STROBE_SOURCE, + V4L2_FLASH_STROBE_SOURCE_EXTERNAL, + ~(1 << V4L2_FLASH_STROBE_SOURCE_EXTERNAL), + V4L2_FLASH_STROBE_SOURCE_EXTERNAL); + ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY; + ret = v4l2_fwnode_device_parse(ov9282->dev, &props); if (!ret) { /* Failure sets ctrl_hdlr->error, which we check afterwards anyway */
Add read-only V4L2_CID_FLASH_STROBE_SOURCE control. Its value is fixed to V4L2_FLASH_STROBE_SOURCE_EXTERNAL as the camera sensor triggers the strobe based on its register settings. Signed-off-by: Richard Leitner <richard.leitner@linux.dev> --- drivers/media/i2c/ov9282.c | 8 ++++++++ 1 file changed, 8 insertions(+)