| Message ID | 20250504101336.18748-5-hdegoede@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: mt9m114: Changes to make it work with atomisp devices | expand |
Hi Hans, Thank you for the patch. On Sun, May 04, 2025 at 12:13:25PM +0200, Hans de Goede wrote: > As the comment above the defines says, the minimum values are undocumented > so the lowest values seen in register lists are used. > > The version of the mt9m114 driver shipped together with the atomisp code > uses 21 for vblank in its register lists, lower MT9M114_MIN_VBLANK > accordingly. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/mt9m114.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c > index 9fdfd90afc22..b40142aed3e8 100644 > --- a/drivers/media/i2c/mt9m114.c > +++ b/drivers/media/i2c/mt9m114.c > @@ -324,13 +324,13 @@ > > /* > * The minimum amount of horizontal and vertical blanking is undocumented. The > - * minimum values that have been seen in register lists are 303 and 38, use > + * minimum values that have been seen in register lists are 303 and 21, use > * them. > * > * Set the default to achieve 1280x960 at 30fps with a 48 MHz pixclock. > */ > #define MT9M114_MIN_HBLANK 303 > -#define MT9M114_MIN_VBLANK 38 > +#define MT9M114_MIN_VBLANK 21 > #define MT9M114_DEF_HBLANK 323 > #define MT9M114_DEF_VBLANK 39 >
diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 9fdfd90afc22..b40142aed3e8 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -324,13 +324,13 @@ /* * The minimum amount of horizontal and vertical blanking is undocumented. The - * minimum values that have been seen in register lists are 303 and 38, use + * minimum values that have been seen in register lists are 303 and 21, use * them. * * Set the default to achieve 1280x960 at 30fps with a 48 MHz pixclock. */ #define MT9M114_MIN_HBLANK 303 -#define MT9M114_MIN_VBLANK 38 +#define MT9M114_MIN_VBLANK 21 #define MT9M114_DEF_HBLANK 323 #define MT9M114_DEF_VBLANK 39
As the comment above the defines says, the minimum values are undocumented so the lowest values seen in register lists are used. The version of the mt9m114 driver shipped together with the atomisp code uses 21 for vblank in its register lists, lower MT9M114_MIN_VBLANK accordingly. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/media/i2c/mt9m114.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)