diff mbox series

pinctrl: at91: drop unneeded dependency on OF_GPIO

Message ID 20250502100841.113091-1-brgl@bgdev.pl
State New
Headers show
Series pinctrl: at91: drop unneeded dependency on OF_GPIO | expand

Commit Message

Bartosz Golaszewski May 2, 2025, 10:08 a.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This driver does not use any symbols from gpiolib-of.c. There's no
reason for it to select OF_GPIO directly. This addresses a kismet issue
reported by the build bot.

Fixes: 8e86af65f39d ("pinctrl: at91: allow building the module with COMPILE_TEST=y")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505010447.kUlI61vt-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/pinctrl/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Linus Walleij May 8, 2025, 8:37 p.m. UTC | #1 
On Fri, May 2, 2025 at 12:09 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This driver does not use any symbols from gpiolib-of.c. There's no
> reason for it to select OF_GPIO directly. This addresses a kismet issue
> reported by the build bot.
>
> Fixes: 8e86af65f39d ("pinctrl: at91: allow building the module with COMPILE_TEST=y")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505010447.kUlI61vt-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Patch applied and pushed out, sorry for the delay!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index db84d80b7e7d3..33db9104df178 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -107,7 +107,6 @@  config PINCTRL_AT91
 	select PINMUX
 	select PINCONF
 	select GPIOLIB
-	select OF_GPIO
 	select GPIOLIB_IRQCHIP
 	help
 	  Say Y here to enable the at91 pinctrl driver