| Message ID | 20250507131143.2243079-1-mike.looijmans@topic.nl |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] usb: misc: onboard_usb_dev: Add support for TI TUSB8044 hub | expand |
On Wed, May 07, 2025 at 03:11:43PM +0200, Mike Looijmans wrote: > The TI USB8044 is similar to the USB8041. Similar how? Why's a fallback not suitable? > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > > Documentation/devicetree/bindings/usb/ti,usb8041.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/ti,usb8041.yaml b/Documentation/devicetree/bindings/usb/ti,usb8041.yaml > index c2e29bd61e11..fd6b35a40a5b 100644 > --- a/Documentation/devicetree/bindings/usb/ti,usb8041.yaml > +++ b/Documentation/devicetree/bindings/usb/ti,usb8041.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/usb/ti,usb8041.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: TI USB8041 USB 3.0 hub controller > +title: TI USB8041 and USB8044 USB 3.0 hub controllers > > maintainers: > - Alexander Stein <alexander.stein@ew.tq-group.com> > @@ -17,6 +17,8 @@ properties: > enum: > - usb451,8140 > - usb451,8142 > + - usb451,8440 > + - usb451,8442 > > reg: true > > -- > 2.34.1 > > > Met vriendelijke groet / kind regards, > > Mike Looijmans > System Expert > > > TOPIC Embedded Products B.V. > Materiaalweg 4, 5681 RJ Best > The Netherlands > > T: +31 (0) 499 33 69 69 > E: mike.looijmans@topic.nl > W: www.topic.nl > > Please consider the environment before printing this e-mail
On 08-05-2025 16:58, Conor Dooley wrote: > On Wed, May 07, 2025 at 03:11:43PM +0200, Mike Looijmans wrote: >> The TI USB8044 is similar to the USB8041. > Similar how? Why's a fallback not suitable? I don't quite understand what is meant by "fallback" here? It's similar in that the USB8044 provides the same functionality and can use the same driver as the USB8041, all that is needed is to add the PID/VID values. M. > >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> --- >> >> Documentation/devicetree/bindings/usb/ti,usb8041.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/ti,usb8041.yaml b/Documentation/devicetree/bindings/usb/ti,usb8041.yaml >> index c2e29bd61e11..fd6b35a40a5b 100644 >> --- a/Documentation/devicetree/bindings/usb/ti,usb8041.yaml >> +++ b/Documentation/devicetree/bindings/usb/ti,usb8041.yaml >> @@ -4,7 +4,7 @@ >> $id: http://devicetree.org/schemas/usb/ti,usb8041.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: TI USB8041 USB 3.0 hub controller >> +title: TI USB8041 and USB8044 USB 3.0 hub controllers >> >> maintainers: >> - Alexander Stein <alexander.stein@ew.tq-group.com> >> @@ -17,6 +17,8 @@ properties: >> enum: >> - usb451,8140 >> - usb451,8142 >> + - usb451,8440 >> + - usb451,8442 >> >> reg: true >> >> -- >> 2.34.1 >> >> >> Met vriendelijke groet / kind regards, >> >> Mike Looijmans >> System Expert >> >> >> TOPIC Embedded Products B.V. >> Materiaalweg 4, 5681 RJ Best >> The Netherlands >> >> T: +31 (0) 499 33 69 69 >> E: mike.looijmans@topic.nl >> W: www.topic.nl >> >> Please consider the environment before printing this e-mail
diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c index 9660b7fe8ee3..c4252186621b 100644 --- a/drivers/usb/misc/onboard_usb_dev.c +++ b/drivers/usb/misc/onboard_usb_dev.c @@ -556,6 +556,8 @@ static const struct usb_device_id onboard_dev_id_table[] = { { USB_DEVICE(VENDOR_ID_TI, 0x8027) }, /* TI USB8020B 2.0 HUB */ { USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 HUB */ { USB_DEVICE(VENDOR_ID_TI, 0x8142) }, /* TI USB8041 2.0 HUB */ + { USB_DEVICE(VENDOR_ID_TI, 0x8440) }, /* TI USB8044 3.0 HUB */ + { USB_DEVICE(VENDOR_ID_TI, 0x8442) }, /* TI USB8044 2.0 HUB */ { USB_DEVICE(VENDOR_ID_VIA, 0x0817) }, /* VIA VL817 3.1 HUB */ { USB_DEVICE(VENDOR_ID_VIA, 0x2817) }, /* VIA VL817 2.0 HUB */ {} diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h index 367c5c418ae6..b0bc53f781e6 100644 --- a/drivers/usb/misc/onboard_usb_dev.h +++ b/drivers/usb/misc/onboard_usb_dev.h @@ -86,6 +86,8 @@ static const struct of_device_id onboard_dev_match[] = { { .compatible = "usb451,8027", .data = &ti_tusb8020b_data, }, { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, + { .compatible = "usb451,8440", .data = &ti_tusb8041_data, }, + { .compatible = "usb451,8442", .data = &ti_tusb8041_data, }, { .compatible = "usb4b4,6504", .data = &cypress_hx3_data, }, { .compatible = "usb4b4,6506", .data = &cypress_hx3_data, }, { .compatible = "usb4b4,6570", .data = &cypress_hx2vl_data, },
The TUSB8044 is similar to the TUSB8041. This adds the PID/VID values and allows to specify the reset GPIO signal on the board. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- drivers/usb/misc/onboard_usb_dev.c | 2 ++ drivers/usb/misc/onboard_usb_dev.h | 2 ++ 2 files changed, 4 insertions(+)