diff mbox series

vt: remove VT_RESIZE and VT_RESIZEX from vt_compat_ioctl()

Message ID pr214s15-36r8-6732-2pop-159nq85o48r7@syhkavp.arg
State New
Headers show
Series vt: remove VT_RESIZE and VT_RESIZEX from vt_compat_ioctl() | expand

Commit Message

Nicolas Pitre May 15, 2025, 3:30 p.m. UTC 
From: Nicolas Pitre <npitre@baylibre.com>

They are listed amon those cmd values that "treat 'arg' as an integer"
which is wrong. They should instead fall into the default case. Probably
nobody ever relied on that code since 2009 but still.

Fixes: e92166517e3c ("tty: handle VT specific compat ioctls in vt driver")
Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
---

Reposting as I screwed up my initial post.
Jiri's analysis can be viewed here:
http://lore.kernel.org/all/184449a6-f2db-4307-8351-66b617a3839b@kernel.org
diff mbox series

Patch

diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index 83a3d49535e5..61342e06970a 100644
--- a/drivers/tty/vt/vt_ioctl.c
+++ b/drivers/tty/vt/vt_ioctl.c
@@ -1119,8 +1119,6 @@  long vt_compat_ioctl(struct tty_struct *tty,
 	case VT_WAITACTIVE:
 	case VT_RELDISP:
 	case VT_DISALLOCATE:
-	case VT_RESIZE:
-	case VT_RESIZEX:
 		return vt_ioctl(tty, cmd, arg);
 
 	/*