| Message ID | 20250519111311.2390-6-wsa+renesas@sang-engineering.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] i2c: powermac: convert of_node usage to fwnode | expand |
> > - info.of_node = of_node_get(node); > > + info.fwnode = of_fwnode_handle(of_node_get(node)); > > What puzzles me here is that of_node_get(). We already do the same in the I²C > core, does it really need the second bump of the reference counting? I'd think so. i2c_board_info has its own source file outside of the I2C core because it is used before the I2C core is even initialized. That is basically the reason for its existence.
Hi Wolfram, On Mon, May 19, 2025 at 01:13:12PM +0200, Wolfram Sang wrote: > 'of_node' in i2c_boardinfo is deprecated in favor of 'fwnode'. The I2C > core handles them equally, so simply convert this driver to fwnode. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> I took this patch in i2c/i2c-host. Please let me know if you want me to take also the others. Thanks, Andi
> I took this patch in i2c/i2c-host. Please let me know if you want > me to take also the others. To avoid the dependency with your PR, is it okay if you drop it and I take this patch via my tree?
Hi Wolfram, On Tue, May 20, 2025 at 11:15:21AM +0200, Wolfram Sang wrote: > > > I took this patch in i2c/i2c-host. Please let me know if you want > > me to take also the others. > > To avoid the dependency with your PR, is it okay if you drop it and I > take this patch via my tree? yes, sure! I will take it out. Thanks, Andi
diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c index 9a867c817db0..f99a2cc721a8 100644 --- a/drivers/i2c/busses/i2c-powermac.c +++ b/drivers/i2c/busses/i2c-powermac.c @@ -349,7 +349,7 @@ static void i2c_powermac_register_devices(struct i2c_adapter *adap, /* Fill out the rest of the info structure */ info.addr = addr; info.irq = irq_of_parse_and_map(node, 0); - info.of_node = of_node_get(node); + info.fwnode = of_fwnode_handle(of_node_get(node)); newdev = i2c_new_client_device(adap, &info); if (IS_ERR(newdev)) {
'of_node' in i2c_boardinfo is deprecated in favor of 'fwnode'. The I2C core handles them equally, so simply convert this driver to fwnode. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/busses/i2c-powermac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)