[v1,1/3] Bluetooth: btintel_pcie: Fix driver not posting maximum rx buffers

The driver was posting only 6 rx buffers, despite the maximum rx buffers
being defined as 16. Update the driver to post the full 16 Rx buffers to
utilize the maximum capacity and improve performance.

Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
Signed-off-by: Kiran K <kiran.k@intel.com>
Fixes: c2b636b3f788 ("Bluetooth: btintel_pcie: Add support for PCIe transport")
---
 drivers/bluetooth/btintel_pcie.c | 3 ++-
 drivers/bluetooth/btintel_pcie.h | 3 ---
 2 files changed, 2 insertions(+), 4 deletions(-)

Dear Kiran,


Thank you for the patch.

Am 25.05.25 um 07:39 schrieb Kiran K:
> The driver was posting only 6 rx buffers, despite the maximum rx buffers
> being defined as 16.

The second part is worded strangely, as the macro, you remove, is 
defined to be 6. Was it just a typo?

> Update the driver to post the full 16 Rx buffers to
> utilize the maximum capacity and improve performance.

Please also note, that you remove the macro, because the value seems to 
be detectable.

Please also mention, how your change can be verified, for example read 
out in the logs or from /sys, and how the performance can be measured, 
and what you measured before and after. (Claimns regarding performance 
should always come with measurements.)

> Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
> Signed-off-by: Kiran K <kiran.k@intel.com>
> Fixes: c2b636b3f788 ("Bluetooth: btintel_pcie: Add support for PCIe transport")
> ---
>   drivers/bluetooth/btintel_pcie.c | 3 ++-
>   drivers/bluetooth/btintel_pcie.h | 3 ---
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 50fe17f1e1d1..2c7731803c9f 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -396,8 +396,9 @@ static int btintel_pcie_submit_rx(struct btintel_pcie_data *data)
>   static int btintel_pcie_start_rx(struct btintel_pcie_data *data)
>   {
>   	int i, ret;
> +	struct rxq *rxq = &data->rxq;
>   
> -	for (i = 0; i < BTINTEL_PCIE_RX_MAX_QUEUE; i++) {
> +	for (i = 0; i < rxq->count; i++) {
>   		ret = btintel_pcie_submit_rx(data);
>   		if (ret)
>   			return ret;
> diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h
> index 21b964b15c1c..5ddd6d7d8d45 100644
> --- a/drivers/bluetooth/btintel_pcie.h
> +++ b/drivers/bluetooth/btintel_pcie.h
> @@ -177,9 +177,6 @@ enum {
>   /* Doorbell vector for TFD */
>   #define BTINTEL_PCIE_TX_DB_VEC	0
>   
> -/* Number of pending RX requests for downlink */
> -#define BTINTEL_PCIE_RX_MAX_QUEUE	6
> -
>   /* Doorbell vector for FRBD */
>   #define BTINTEL_PCIE_RX_DB_VEC	513


Kind regards,

Paul

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=966178

---Test result---

Test Summary:
CheckPatch                    PENDING   0.33 seconds
GitLint                       PENDING   0.21 seconds
SubjectPrefix                 PASS      0.34 seconds
BuildKernel                   PASS      24.56 seconds
CheckAllWarning               PASS      26.73 seconds
CheckSparse                   PASS      30.13 seconds
BuildKernel32                 PASS      23.98 seconds
TestRunnerSetup               PASS      452.70 seconds
TestRunner_l2cap-tester       PASS      25.09 seconds
TestRunner_iso-tester         PASS      37.26 seconds
TestRunner_bnep-tester        PASS      5.86 seconds
TestRunner_mgmt-tester        PASS      131.88 seconds
TestRunner_rfcomm-tester      PASS      9.27 seconds
TestRunner_sco-tester         PASS      14.55 seconds
TestRunner_ioctl-tester       PASS      9.89 seconds
TestRunner_mesh-tester        PASS      7.30 seconds
TestRunner_smp-tester         PASS      8.71 seconds
TestRunner_userchan-tester    PASS      6.09 seconds
IncrementalBuild              PENDING   0.94 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth