| Message ID | aDVTtQdXVtRhxOrb@stanley.mountain |
|---|---|
| State | New |
| Headers | show |
| Series | [next] mmc: sdhci-of-k1: Fix error code in probe() | expand |
On Tue, 27 May 2025 at 07:55, Dan Carpenter <dan.carpenter@linaro.org> wrote: > > If spacemit_sdhci_get_clocks() fails, then propagate the error code. > Don't return success. > > Fixes: e5502d15b0f3 ("mmc: sdhci-of-k1: add support for SpacemiT K1 SoC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Applied for fixes, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-k1.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-k1.c b/drivers/mmc/host/sdhci-of-k1.c > index 6880d3e9ab62..2e5da7c5834c 100644 > --- a/drivers/mmc/host/sdhci-of-k1.c > +++ b/drivers/mmc/host/sdhci-of-k1.c > @@ -276,7 +276,8 @@ static int spacemit_sdhci_probe(struct platform_device *pdev) > > host->mmc->caps |= MMC_CAP_NEED_RSP_BUSY; > > - if (spacemit_sdhci_get_clocks(dev, pltfm_host)) > + ret = spacemit_sdhci_get_clocks(dev, pltfm_host); > + if (ret) > goto err_pltfm; > > ret = sdhci_add_host(host); > -- > 2.47.2 >
diff --git a/drivers/mmc/host/sdhci-of-k1.c b/drivers/mmc/host/sdhci-of-k1.c index 6880d3e9ab62..2e5da7c5834c 100644 --- a/drivers/mmc/host/sdhci-of-k1.c +++ b/drivers/mmc/host/sdhci-of-k1.c @@ -276,7 +276,8 @@ static int spacemit_sdhci_probe(struct platform_device *pdev) host->mmc->caps |= MMC_CAP_NEED_RSP_BUSY; - if (spacemit_sdhci_get_clocks(dev, pltfm_host)) + ret = spacemit_sdhci_get_clocks(dev, pltfm_host); + if (ret) goto err_pltfm; ret = sdhci_add_host(host);
If spacemit_sdhci_get_clocks() fails, then propagate the error code. Don't return success. Fixes: e5502d15b0f3 ("mmc: sdhci-of-k1: add support for SpacemiT K1 SoC") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/mmc/host/sdhci-of-k1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)