| Message ID | 20250603100440.600346-1-kiran.k@intel.com |
|---|---|
| State | Accepted |
| Commit | 31b3d39c89f99eb9f1369e43da351a6bddb416dd |
| Headers | show |
| Series | [v3,1/3] Bluetooth: btintel_pcie: Fix driver not posting maximum rx buffers | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=968236 ---Test result--- Test Summary: CheckPatch PENDING 0.40 seconds GitLint PENDING 0.34 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 24.50 seconds CheckAllWarning PASS 27.26 seconds CheckSparse PASS 30.68 seconds BuildKernel32 PASS 24.40 seconds TestRunnerSetup PASS 460.82 seconds TestRunner_l2cap-tester PASS 25.20 seconds TestRunner_iso-tester PASS 41.49 seconds TestRunner_bnep-tester PASS 5.79 seconds TestRunner_mgmt-tester PASS 129.88 seconds TestRunner_rfcomm-tester PASS 9.46 seconds TestRunner_sco-tester PASS 14.80 seconds TestRunner_ioctl-tester PASS 10.02 seconds TestRunner_mesh-tester PASS 7.33 seconds TestRunner_smp-tester PASS 8.55 seconds TestRunner_userchan-tester PASS 6.35 seconds IncrementalBuild PENDING 0.63 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 3 Jun 2025 15:34:38 +0530 you wrote: > The driver was posting only 6 rx buffers, despite the maximum rx buffers > being defined as 16. Having fewer RX buffers caused firmware exceptions > in HID use cases when events arrived in bursts. > > Exception seen on android 6.12 kernel. > > E Bluetooth: hci0: Received hw exception interrupt > E Bluetooth: hci0: Received gp1 mailbox interrupt > D Bluetooth: hci0: 00000000: ff 3e 87 80 03 01 01 01 03 01 0c 0d 02 1c 10 0e > D Bluetooth: hci0: 00000010: 01 00 05 14 66 b0 28 b0 c0 b0 28 b0 ac af 28 b0 > D Bluetooth: hci0: 00000020: 14 f1 28 b0 00 00 00 00 fa 04 00 00 00 00 40 10 > D Bluetooth: hci0: 00000030: 08 00 00 00 7a 7a 7a 7a 47 00 fb a0 10 00 00 00 > D Bluetooth: hci0: 00000000: 10 01 0a > E Bluetooth: hci0: ---- Dump of debug registers — > E Bluetooth: hci0: boot stage: 0xe0fb0047 > E Bluetooth: hci0: ipc status: 0x00000004 > E Bluetooth: hci0: ipc control: 0x00000000 > E Bluetooth: hci0: ipc sleep control: 0x00000000 > E Bluetooth: hci0: mbox_1: 0x00badbad > E Bluetooth: hci0: mbox_2: 0x0000101c > E Bluetooth: hci0: mbox_3: 0x00000008 > E Bluetooth: hci0: mbox_4: 0x7a7a7a7a > > [...] Here is the summary with links: - [v3,1/3] Bluetooth: btintel_pcie: Fix driver not posting maximum rx buffers https://git.kernel.org/bluetooth/bluetooth-next/c/31b3d39c89f9 - [v3,2/3] Bluetooth: btintel_pcie: Increase the tx and rx descriptor count https://git.kernel.org/bluetooth/bluetooth-next/c/e849b59c9db0 You are awesome, thank you!
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c index 50fe17f1e1d1..2c7731803c9f 100644 --- a/drivers/bluetooth/btintel_pcie.c +++ b/drivers/bluetooth/btintel_pcie.c @@ -396,8 +396,9 @@ static int btintel_pcie_submit_rx(struct btintel_pcie_data *data) static int btintel_pcie_start_rx(struct btintel_pcie_data *data) { int i, ret; + struct rxq *rxq = &data->rxq; - for (i = 0; i < BTINTEL_PCIE_RX_MAX_QUEUE; i++) { + for (i = 0; i < rxq->count; i++) { ret = btintel_pcie_submit_rx(data); if (ret) return ret; diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h index 21b964b15c1c..5ddd6d7d8d45 100644 --- a/drivers/bluetooth/btintel_pcie.h +++ b/drivers/bluetooth/btintel_pcie.h @@ -177,9 +177,6 @@ enum { /* Doorbell vector for TFD */ #define BTINTEL_PCIE_TX_DB_VEC 0 -/* Number of pending RX requests for downlink */ -#define BTINTEL_PCIE_RX_MAX_QUEUE 6 - /* Doorbell vector for FRBD */ #define BTINTEL_PCIE_RX_DB_VEC 513