| Message ID | 1483272678-14444-8-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Jagan, On 01/01/2017 09:11 PM, Masahiro Yamada wrote: > The bare default entry is wrong. Just remove it since the (real) > entry in drivers/mmc/Kconfig has "default ARM || PPC || SANDBOX". Do you have any opinion about this patch? I want to know your ack or review. If there is no objection, i will pick this patch on my repository. Best Regards, Jaehoon Chung > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > board/sunxi/Kconfig | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig > index e1d4ab1..11eb82a 100644 > --- a/board/sunxi/Kconfig > +++ b/board/sunxi/Kconfig > @@ -291,10 +291,6 @@ config OLD_SUNXI_KERNEL_COMPAT > Set this to enable various workarounds for old kernels, this results in > sub-optimal settings for newer kernels, only enable if needed. > > -config MMC > - depends on !UART0_PORT_F > - default y if ARCH_SUNXI > - > config MMC0_CD_PIN > string "Card detect pin for mmc0" > default "PF6" if MACH_SUN8I_A83T || MACH_SUN8I_H3 || MACH_SUN50I > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Hi Jaehoon, 2017-01-10 9:55 GMT+09:00 Jaehoon Chung <jh80.chung@samsung.com>: > Hi Jagan, > > On 01/01/2017 09:11 PM, Masahiro Yamada wrote: >> The bare default entry is wrong. Just remove it since the (real) >> entry in drivers/mmc/Kconfig has "default ARM || PPC || SANDBOX". > > Do you have any opinion about this patch? > I want to know your ack or review. > If there is no objection, i will pick this patch on my repository. > > Best Regards, > Jaehoon Chung If you are going to pick up this series, please be careful with invisible conflicts. Applying the series as-is will cause misconversion because it is already outdated. You can re-generate the series with commands in each commit-log, or I can re-send the series based on the v2017.01 tag if requested. -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Hi Masahiro, On 01/10/2017 10:32 AM, Masahiro Yamada wrote: > Hi Jaehoon, > > > 2017-01-10 9:55 GMT+09:00 Jaehoon Chung <jh80.chung@samsung.com>: >> Hi Jagan, >> >> On 01/01/2017 09:11 PM, Masahiro Yamada wrote: >>> The bare default entry is wrong. Just remove it since the (real) >>> entry in drivers/mmc/Kconfig has "default ARM || PPC || SANDBOX". >> >> Do you have any opinion about this patch? >> I want to know your ack or review. >> If there is no objection, i will pick this patch on my repository. >> >> Best Regards, >> Jaehoon Chung > > If you are going to pick up this series, > please be careful with invisible conflicts. > Applying the series as-is will cause misconversion > because it is already outdated. > > You can re-generate the series with commands in each commit-log, > or I can re-send the series based on the v2017.01 tag if requested. Yes, i'm running buildman with these patches on v2017.01 tag. If you can resend the patches, it's more helpful to me with Marek's reviewed-tag. To prevent the conflict, i think it's good to apply ASAP. Best Regards, Jaehoon Chung > > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Hi Jaehoon, 2017-01-10 10:41 GMT+09:00 Jaehoon Chung <jh80.chung@samsung.com>: > Hi Masahiro, > > On 01/10/2017 10:32 AM, Masahiro Yamada wrote: >> Hi Jaehoon, >> >> >> 2017-01-10 9:55 GMT+09:00 Jaehoon Chung <jh80.chung@samsung.com>: >>> Hi Jagan, >>> >>> On 01/01/2017 09:11 PM, Masahiro Yamada wrote: >>>> The bare default entry is wrong. Just remove it since the (real) >>>> entry in drivers/mmc/Kconfig has "default ARM || PPC || SANDBOX". >>> >>> Do you have any opinion about this patch? >>> I want to know your ack or review. >>> If there is no objection, i will pick this patch on my repository. >>> >>> Best Regards, >>> Jaehoon Chung >> >> If you are going to pick up this series, >> please be careful with invisible conflicts. >> Applying the series as-is will cause misconversion >> because it is already outdated. >> >> You can re-generate the series with commands in each commit-log, >> or I can re-send the series based on the v2017.01 tag if requested. > > Yes, i'm running buildman with these patches on v2017.01 tag. > If you can resend the patches, it's more helpful to me with Marek's reviewed-tag. > To prevent the conflict, i think it's good to apply ASAP. > > Best Regards, > Jaehoon Chung > I re-generated the entire series on top of the v2017.01 tag. The difference from the v1 was only configs/cl-som-am57x_defconfig -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig index e1d4ab1..11eb82a 100644 --- a/board/sunxi/Kconfig +++ b/board/sunxi/Kconfig @@ -291,10 +291,6 @@ config OLD_SUNXI_KERNEL_COMPAT Set this to enable various workarounds for old kernels, this results in sub-optimal settings for newer kernels, only enable if needed. -config MMC - depends on !UART0_PORT_F - default y if ARCH_SUNXI - config MMC0_CD_PIN string "Card detect pin for mmc0" default "PF6" if MACH_SUN8I_A83T || MACH_SUN8I_H3 || MACH_SUN50I
The bare default entry is wrong. Just remove it since the (real) entry in drivers/mmc/Kconfig has "default ARM || PPC || SANDBOX". Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- board/sunxi/Kconfig | 4 ---- 1 file changed, 4 deletions(-) -- 2.7.4 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot