diff mbox

[v6,03/14] ACPI: ARM64: IORT: add missing comment for iort_dev_find_its_id()

Message ID 1483363905-2806-4-git-send-email-hanjun.guo@linaro.org
State Accepted
Commit 6cb6bf56dc15ec3954186524cd9a41347a18ebc8
Headers show

Commit Message

Hanjun Guo Jan. 2, 2017, 1:31 p.m. UTC 
We are missing req_id's comment for iort_dev_find_its_id(),
add it back.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>

Tested-by: Majun <majun258@huawei.com>

Tested-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>

Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Tomasz Nowicki <tn@semihalf.com>
---
 drivers/acpi/arm64/iort.c | 1 +
 1 file changed, 1 insertion(+)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Lorenzo Pieralisi Jan. 4, 2017, 2:34 p.m. UTC | #1 
On Mon, Jan 02, 2017 at 09:31:34PM +0800, Hanjun Guo wrote:
> We are missing req_id's comment for iort_dev_find_its_id(),

> add it back.


"Add missing req_id parameter to the iort_dev_find_its_id() function
kernel-doc comment."

> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>

> Tested-by: Majun <majun258@huawei.com>

> Tested-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>

> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> Cc: Tomasz Nowicki <tn@semihalf.com>

> ---

>  drivers/acpi/arm64/iort.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c

> index 46e2d82..174e983 100644

> --- a/drivers/acpi/arm64/iort.c

> +++ b/drivers/acpi/arm64/iort.c

> @@ -446,6 +446,7 @@ u32 iort_msi_map_rid(struct device *dev, u32 req_id)

>  /**

>   * iort_dev_find_its_id() - Find the ITS identifier for a device

>   * @dev: The device.

> + * @req_id: Device's Requster ID


s/Requster/Requester

We can send it upstream independently along with some other patches
in this series but I will have a look at the whole series first.

Lorenzo

>   * @idx: Index of the ITS identifier list.

>   * @its_id: ITS identifier.

>   *

> -- 

> 1.9.1

> 

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 46e2d82..174e983 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -446,6 +446,7 @@  u32 iort_msi_map_rid(struct device *dev, u32 req_id)
 /**
  * iort_dev_find_its_id() - Find the ITS identifier for a device
  * @dev: The device.
+ * @req_id: Device's Requster ID
  * @idx: Index of the ITS identifier list.
  * @its_id: ITS identifier.
  *