| Message ID | 20250611180956.2780365-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] pinctrl: intel: fix build warnings about export.h | expand |
On Wed, Jun 11, 2025 at 09:09:56PM +0300, Andy Shevchenko wrote: > After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include > <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check: > check unnecessary #include <linux/export.h> when W=1"), we get some build > warnings with W=1: > > pinctrl-intel.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > So fix these build warnings for the driver code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Thu, Jun 12, 2025 at 08:12:58AM +0300, Mika Westerberg wrote: > On Wed, Jun 11, 2025 at 09:09:56PM +0300, Andy Shevchenko wrote: > > After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include > > <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check: > > check unnecessary #include <linux/export.h> when W=1"), we get some build > > warnings with W=1: > > > > pinctrl-intel.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > > > So fix these build warnings for the driver code. > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Pushed to my review and testing queue, thanks!
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index d889c7c878e2..15f91fa198a3 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -9,6 +9,7 @@ #include <linux/acpi.h> #include <linux/cleanup.h> +#include <linux/export.h> #include <linux/gpio/driver.h> #include <linux/interrupt.h> #include <linux/log2.h>
After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check: check unnecessary #include <linux/export.h> when W=1"), we get some build warnings with W=1: pinctrl-intel.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing So fix these build warnings for the driver code. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 1 + 1 file changed, 1 insertion(+)