| Message ID | 20250614-msm8960-sdcard-v1-1-ccce629428b6@smankusors.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Sony Xperia SP | expand |
On 6/13/25 7:50 PM, Antony Kurniawan Soemardi wrote: > Adds sdcc3-default-state and sdcc3-sleep-state pinctrl states for > MSM8960. These are required for devices like Sony Xperia SP to ensure > micro SD card functionality, though they are a no-op on the Samsung > Galaxy Express. > > Tested-by: Rudraksha Gupta <guptarud@gmail.com> > Signed-off-by: Antony Kurniawan Soemardi <linux@smankusors.com> > --- > arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi | 38 ++++++++++++++++++++++ > .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 5 +++ > 2 files changed, 43 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi > index 4fa98277128897a531c54296576a6f15cd6d2a28..77fe5be24b36fbda83ba73034939db10db6ef4c8 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi > @@ -18,4 +18,42 @@ i2c3-pins { > bias-bus-hold; > }; > }; > + > + sdcc3_default_state: sdcc3-default-state { > + clk-pins { > + pins = "sdc3_clk"; > + drive-strength = <8>; > + bias-disable; > + }; > + > + cmd-pins { > + pins = "sdc3_cmd"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > + data-pins { > + pins = "sdc3_data"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + }; > + > + sdcc3_sleep_state: sdcc3-sleep-state { > + clk-pins { > + pins = "sdc3_clk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cmd-pins { > + pins = "sdc3_cmd"; > + drive-strength = <2>; > + }; > + > + data-pins { > + pins = "sdc3_data"; > + drive-strength = <2>; Please add bias-pull-up to these two as well, just to be explicit Konrad
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi index 4fa98277128897a531c54296576a6f15cd6d2a28..77fe5be24b36fbda83ba73034939db10db6ef4c8 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi @@ -18,4 +18,42 @@ i2c3-pins { bias-bus-hold; }; }; + + sdcc3_default_state: sdcc3-default-state { + clk-pins { + pins = "sdc3_clk"; + drive-strength = <8>; + bias-disable; + }; + + cmd-pins { + pins = "sdc3_cmd"; + drive-strength = <8>; + bias-pull-up; + }; + + data-pins { + pins = "sdc3_data"; + drive-strength = <8>; + bias-pull-up; + }; + }; + + sdcc3_sleep_state: sdcc3-sleep-state { + clk-pins { + pins = "sdc3_clk"; + drive-strength = <2>; + bias-disable; + }; + + cmd-pins { + pins = "sdc3_cmd"; + drive-strength = <2>; + }; + + data-pins { + pins = "sdc3_data"; + drive-strength = <2>; + }; + }; }; diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts index af6cc6393d740d30f3555825175ea6851d406166..49d117ea033a0ef73c134d1225982786fbded2c2 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts @@ -71,6 +71,11 @@ &sdcc1 { &sdcc3 { vmmc-supply = <&pm8921_l6>; vqmmc-supply = <&pm8921_l7>; + + pinctrl-0 = <&sdcc3_default_state>; + pinctrl-1 = <&sdcc3_sleep_state>; + pinctrl-names = "default", "sleep"; + status = "okay"; };