| Message ID | 20250613055613.866909-5-pritam.sutar@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | initial usbdrd phy support for Exynosautov920 soc | expand |
On Fri, Jun 13, 2025 at 11:26:08AM GMT, Pritam Manohar Sutar wrote:
> Add a dedicated compatible string for USB combo HS phy found in this
I reviewed patch #1, then went here and see that this is HS PHY. So
patch #1 is not HS PHY?
Best regards,
Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 16 June 2025 01:46 PM > To: Pritam Manohar Sutar <pritam.sutar@samsung.com> > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; m.szyprowski@samsung.com; > s.nawrocki@samsung.com; linux-phy@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; > rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v3 4/9] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 combo HS phy > > On Fri, Jun 13, 2025 at 11:26:08AM GMT, Pritam Manohar Sutar wrote: > > Add a dedicated compatible string for USB combo HS phy found in this > > I reviewed patch #1, then went here and see that this is HS PHY. So patch #1 > is not HS PHY? > https://lore.kernel.org/linux-phy/20250613055613.866909-1-pritam.sutar@samsung.com/ This Soc has 2 types HS phys. one in combo phy and another stand-alone. please refer the block diagrams in cover-letter. 1. samsung,exynosautov920-usbdrd-phy => represents hs phy (synopsys phy version-303) and it is same as "samsung,exynos850-usbdrd-phy". used same naming conventions 2. samsung,exynosautov920-usbdrd-hsphy => represents 'Add-on' HS phy(synopsys phy version-400) with SS phy in combo phy. this is different from "samsung,exynosautov920-usbdrd-phy" (reg offsets and bits are different). samsung,exynosautov920-usb31drd-ssphy => represents SS phy in combo phy > Best regards, > Krzysztof Thank you. Regards, Pritam
diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml index 71db17d93c6a..26660799e3ca 100644 --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml @@ -33,6 +33,7 @@ properties: - samsung,exynos7-usbdrd-phy - samsung,exynos7870-usbdrd-phy - samsung,exynos850-usbdrd-phy + - samsung,exynosautov920-usbdrd-hsphy - samsung,exynosautov920-usbdrd-phy clocks: @@ -218,6 +219,7 @@ allOf: - samsung,exynos5420-usbdrd-phy - samsung,exynos7870-usbdrd-phy - samsung,exynos850-usbdrd-phy + - samsung,exynosautov920-usbdrd-hsphy - samsung,exynosautov920-usbdrd-phy then: properties:
Add a dedicated compatible string for USB combo HS phy found in this SoC. The devicetree node requires two clocks, named "phy" and "ref". This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards compatible to the USB3.0 SS(5Gbps). 'Add-on USB2.0' phy is added to support USB2.0 HS(480Mbps), FS(12Mbps) and LS(1.5Mbps) data rates. These two phys are combined to form a combo phy. Add schema only for 'Add-on USB2.0' HS phy. Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> --- Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml | 2 ++ 1 file changed, 2 insertions(+)