| Message ID | 94151cfbcff5e4ae05894981c7e398b605d4b00a.1750059796.git.michal.simek@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] dt-bindings: gpio: gpio-xilinx: Mark clocks as required property | expand |
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Mon, 16 Jun 2025 09:43:18 +0200, Michal Simek wrote: > On Microblaze platforms there is no need to handle clocks because the > system is starting with clocks enabled (can be described via fixed clock > node or clock-frequency property or not described at all). > With using soft IPs with SOC platforms there is mandatory to handle clocks > as is explained in commit 60dbdc6e08d6 ("dt-bindings: net: emaclite: Add > clock support"). > That's why make clock as required in dt binding because it is present in > both configurations and should be described even there is no way how to > handle it on Microblaze systems. > > [...] Applied, thanks! [1/1] dt-bindings: gpio: gpio-xilinx: Mark clocks as required property https://git.kernel.org/brgl/linux/c/d03b53c9139352b744ed007bf562bd35517bacff Best regards,
diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.yaml b/Documentation/devicetree/bindings/fpga/fpga-region.yaml index 77554885a6c4..7d2d3b7aa4b7 100644 --- a/Documentation/devicetree/bindings/fpga/fpga-region.yaml +++ b/Documentation/devicetree/bindings/fpga/fpga-region.yaml @@ -316,6 +316,7 @@ examples: reg = <0x40000000 0x10000>; gpio-controller; #gpio-cells = <2>; + clocks = <&clk>; }; }; diff --git a/Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml b/Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml index 8fbf12ca067e..7af4eb2d1858 100644 --- a/Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml +++ b/Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml @@ -117,6 +117,7 @@ properties: required: - reg - compatible + - clocks - gpio-controller - "#gpio-cells"
On Microblaze platforms there is no need to handle clocks because the system is starting with clocks enabled (can be described via fixed clock node or clock-frequency property or not described at all). With using soft IPs with SOC platforms there is mandatory to handle clocks as is explained in commit 60dbdc6e08d6 ("dt-bindings: net: emaclite: Add clock support"). That's why make clock as required in dt binding because it is present in both configurations and should be described even there is no way how to handle it on Microblaze systems. There is also need to describe missing axi gpio clock in fpga-region.yaml not to introduce new error when make dt_binding_check runs. Signed-off-by: Michal Simek <michal.simek@amd.com> Reviewed-by: Xu Yilun <yilun.xu@intel.com> # fpga --- Changes in v3: - Squash 2 patches from series 2 together and update commit to cover it. Changes in v2: - Add fpga region patch to fix issue which was introduces by this change - New patch to fix reported as issue by the second patch - https://lore.kernel.org/r/174954437576.4177094.15371626866789542129.robh@kernel.org Based on discussion at https://lore.kernel.org/lkml/20241002-revivable-crummy-f780adec538c@spud/ Actually this shouldn't be only targetting GPIO but also for example xlnx,xps-timebase-wdt-1.00.a but I would like to check it first on gpio before starting to check other bindings. --- Documentation/devicetree/bindings/fpga/fpga-region.yaml | 1 + Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml | 1 + 2 files changed, 2 insertions(+)