diff mbox series

[v6,10/24] thermal: intel: int340x: processor_thermal: convert to use devm_request*_irq_probe()

Message ID 20250623123743.473677-1-panchuang@vivo.com
State New
Headers show
Series [v6,01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe() | expand

Commit Message

Pan Chuang June 23, 2025, 12:37 p.m. UTC 
From: Yangtao Li <frank.li@vivo.com>

The new devm_request_*irq_probe API prints an error message by default
when the request fails, and consumers can provide custom error messages.

Converting drivers to use this API has the following benefits:

  1.More than 2,000 lines of code can be saved by removing redundant error
  messages in drivers.

  2.Upper-layer functions can directly return error codes without missing
  debugging information.

  3.Having proper and consistent information about why the device cannot
  be used is useful.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 .../processor_thermal_device_pci.c            | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)
diff mbox series

Patch

diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
index 00160936070a..d3e3a53511c4 100644
--- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
+++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
@@ -305,13 +305,13 @@  static int proc_thermal_setup_msi(struct pci_dev *pdev, struct proc_thermal_pci
 	for (i = 0; i < count; i++) {
 		irq =  pci_irq_vector(pdev, i);
 
-		ret = devm_request_threaded_irq(&pdev->dev, irq, proc_thermal_irq_handler,
-						proc_thermal_irq_thread_handler,
-						0, KBUILD_MODNAME, pci_info);
-		if (ret) {
-			dev_err(&pdev->dev, "Request IRQ %d failed\n", irq);
+		ret = devm_request_threaded_irq_probe(&pdev->dev, irq,
+						      proc_thermal_irq_handler,
+						      proc_thermal_irq_thread_handler,
+						      0, KBUILD_MODNAME,
+						      pci_info, NULL);
+		if (ret)
 			goto err_free_msi_vectors;
-		}
 
 		proc_thermal_msi_map[i] = irq;
 	}
@@ -391,13 +391,13 @@  static int proc_thermal_pci_probe(struct pci_dev *pdev, const struct pci_device_
 		irq_flag = IRQF_SHARED;
 		irq = pdev->irq;
 
-		ret = devm_request_threaded_irq(&pdev->dev, irq, proc_thermal_irq_handler,
-						proc_thermal_irq_thread_handler, irq_flag,
-						KBUILD_MODNAME, pci_info);
-		if (ret) {
-			dev_err(&pdev->dev, "Request IRQ %d failed\n", pdev->irq);
+		ret = devm_request_threaded_irq_probe(&pdev->dev, irq,
+						      proc_thermal_irq_handler,
+						      proc_thermal_irq_thread_handler,
+						      irq_flag, KBUILD_MODNAME,
+						      pci_info, NULL);
+		if (ret)
 			goto err_ret_tzone;
-		}
 	}
 
 	ret = thermal_zone_device_enable(pci_info->tzone);