[SCSI] qla2xxx: Remove version.h header file inclusion

Message ID 1338742621-11044-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat June 3, 2012, 4:57 p.m.
version.h header file is no longer required.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/scsi/qla2xxx/qla_target.c |    1 -
 drivers/scsi/qla2xxx/qla_target.h |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

Comments

Nicholas A. Bellinger June 3, 2012, 7:51 p.m. | #1
On Sun, 2012-06-03 at 22:27 +0530, Sachin Kamat wrote:
> version.h header file is no longer required.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/scsi/qla2xxx/qla_target.c |    1 -
>  drivers/scsi/qla2xxx/qla_target.h |    1 -
>  2 files changed, 0 insertions(+), 2 deletions(-)
> 

Hi Sachin,

> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 04f80eb..f7a49e4 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -26,7 +26,6 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  #include <linux/blkdev.h>
>  #include <linux/interrupt.h>
>  #include <linux/pci.h>
> diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
> index 9ec19bc..9f9ef16 100644
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -919,7 +919,6 @@ struct qla_tgt_srr_ctio {
>  #define QLA_TGT_XMIT_STATUS		2
>  #define QLA_TGT_XMIT_ALL		(QLA_TGT_XMIT_STATUS|QLA_TGT_XMIT_DATA)
>  
> -#include <linux/version.h>
>  
>  extern struct qla_tgt_data qla_target;
>  /*

Looks fine to me..

Acked-by: Nicholas Bellinger <nab@linux-iscsi.org>

Patch

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 04f80eb..f7a49e4 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -26,7 +26,6 @@ 
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/types.h>
-#include <linux/version.h>
 #include <linux/blkdev.h>
 #include <linux/interrupt.h>
 #include <linux/pci.h>
diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
index 9ec19bc..9f9ef16 100644
--- a/drivers/scsi/qla2xxx/qla_target.h
+++ b/drivers/scsi/qla2xxx/qla_target.h
@@ -919,7 +919,6 @@  struct qla_tgt_srr_ctio {
 #define QLA_TGT_XMIT_STATUS		2
 #define QLA_TGT_XMIT_ALL		(QLA_TGT_XMIT_STATUS|QLA_TGT_XMIT_DATA)
 
-#include <linux/version.h>
 
 extern struct qla_tgt_data qla_target;
 /*