| Message ID | 5877B52B.9000401@foss.arm.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Jan 12, 2017 at 04:56:11PM +0000, Kyrill Tkachov wrote: > Hi all, > > As discussed in the PR it's better to pin down the tuning for arm targets on this test so that the BRANCH_COST remains constant. > This makes the test more stable across toolchains configured for different default CPUs. > > Ok to apply? > > Thanks, > Kyrill > > 2017-01-12 Kyrylo Tkachov <kyrylo.tkachov@arm.com> > > PR tree-optimization/78319 > * gcc.dg/uninit-pred-8_a.c: Add -mtune=cortex-a15 for arm. > Remove xfail. Ok, thanks. Jakub
diff --git a/gcc/testsuite/gcc.dg/uninit-pred-8_a.c b/gcc/testsuite/gcc.dg/uninit-pred-8_a.c index c45fba0..c4cdf48 100644 --- a/gcc/testsuite/gcc.dg/uninit-pred-8_a.c +++ b/gcc/testsuite/gcc.dg/uninit-pred-8_a.c @@ -1,6 +1,8 @@ /* { dg-do compile } */ /* { dg-options "-Wuninitialized -O2" } */ +/* Pick a particular tuning to pin down BRANCH_COST. */ +/* { dg-additional-options "-mtune=cortex-a15" { target arm*-*-* } } */ int g; void bar(); @@ -16,9 +18,8 @@ int foo (int n, int l, int m, int r) if (m) g++; else bar(); - /* marking this test as xfail on arm-none-eabi, see PR78319. */ if ( n || m || r || l) - blah(v); /* { dg-bogus "uninitialized" "bogus warning" { xfail arm-none-eabi } } */ + blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */ if ( n ) blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */
Hi all, As discussed in the PR it's better to pin down the tuning for arm targets on this test so that the BRANCH_COST remains constant. This makes the test more stable across toolchains configured for different default CPUs. Ok to apply? Thanks, Kyrill 2017-01-12 Kyrylo Tkachov <kyrylo.tkachov@arm.com> PR tree-optimization/78319 * gcc.dg/uninit-pred-8_a.c: Add -mtune=cortex-a15 for arm. Remove xfail.