[3/7] arm64: arm_arch_timer: remove fsl-a008585 parameter

Message ID 1485865196-12742-4-git-send-email-mark.rutland@arm.com
State Superseded
Headers show
Series
  • arm64: arch_timer: work around Hisilicon erratum 161010101
Related show

Commit Message

Mark Rutland Jan. 31, 2017, 12:19 p.m.
From: Ding Tianhong <dingtianhong@huawei.com>


Having a command line option to flip the errata handling for a
particular erratum is a little bit unusual, and it's vastly superior to
pass this in the DT. By common consensus, it's best to kill off the
command line parameter.

Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>

[Mark: split patch, reword commit message]
Signed-off-by: Mark Rutland <mark.rutland@arm.com>

---
 Documentation/admin-guide/kernel-parameters.txt |  9 ---------
 drivers/clocksource/arm_arch_timer.c            | 14 --------------
 2 files changed, 23 deletions(-)

-- 
1.9.1

Comments

Daniel Lezcano Feb. 1, 2017, 10:08 a.m. | #1
On Tue, Jan 31, 2017 at 12:19:52PM +0000, Mark Rutland wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>

> 

> Having a command line option to flip the errata handling for a

> particular erratum is a little bit unusual, and it's vastly superior to

> pass this in the DT. By common consensus, it's best to kill off the

> command line parameter.

> 

> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>

> [Mark: split patch, reword commit message]

> Signed-off-by: Mark Rutland <mark.rutland@arm.com>

> ---


Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>


-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Patch

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index be7c0d9..d8fc55a 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -549,15 +549,6 @@ 
 			loops can be debugged more effectively on production
 			systems.
 
-	clocksource.arm_arch_timer.fsl-a008585=
-			[ARM64]
-			Format: <bool>
-			Enable/disable the workaround of Freescale/NXP
-			erratum A-008585.  This can be useful for KVM
-			guests, if the guest device tree doesn't show the
-			erratum.  If unspecified, the workaround is
-			enabled based on the device tree.
-
 	clearcpuid=BITNUM [X86]
 			Disable CPUID feature X for the kernel. See
 			arch/x86/include/asm/cpufeatures.h for the valid bit
diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 4c8c3fb..6a9d031 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -101,20 +101,6 @@  static int __init early_evtstrm_cfg(char *buf)
 
 static int fsl_a008585_enable = -1;
 
-static int __init early_fsl_a008585_cfg(char *buf)
-{
-	int ret;
-	bool val;
-
-	ret = strtobool(buf, &val);
-	if (ret)
-		return ret;
-
-	fsl_a008585_enable = val;
-	return 0;
-}
-early_param("clocksource.arm_arch_timer.fsl-a008585", early_fsl_a008585_cfg);
-
 u32 __fsl_a008585_read_cntp_tval_el0(void)
 {
 	return __fsl_a008585_read_reg(cntp_tval_el0);