diff mbox

pwm: remove unneeded ifdef CONFIG_DM_PWM ... endif

Message ID 1486019051-8879-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 4985012b73f298e514dea0af46106a107348bce1
Headers show

Commit Message

Masahiro Yamada Feb. 2, 2017, 7:04 a.m. UTC
Both CONFIG_PWM_TEGRA and CONFIG_PWM_EXYNOS depend on CONFIG_DM_PWM,
i.e. they are already guarded by Kconfig correctly.  Remove unneeded
ifdef CONFIG_DM_PWM ... endif.

While we are here, let's tidy up alignment and sort the lines
alphabetically in Makefile.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 drivers/pwm/Makefile | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

-- 
2.7.4

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Comments

Simon Glass Feb. 6, 2017, 3:34 p.m. UTC | #1
On 1 February 2017 at 23:04, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Both CONFIG_PWM_TEGRA and CONFIG_PWM_EXYNOS depend on CONFIG_DM_PWM,

> i.e. they are already guarded by Kconfig correctly.  Remove unneeded

> ifdef CONFIG_DM_PWM ... endif.

>

> While we are here, let's tidy up alignment and sort the lines

> alphabetically in Makefile.

>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---

>

>  drivers/pwm/Makefile | 13 ++++++-------

>  1 file changed, 6 insertions(+), 7 deletions(-)


Reviewed-by: Simon Glass <sjg@chromium.org>

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Tom Rini Feb. 9, 2017, 3:02 a.m. UTC | #2
On Thu, Feb 02, 2017 at 04:04:11PM +0900, Masahiro Yamada wrote:

> Both CONFIG_PWM_TEGRA and CONFIG_PWM_EXYNOS depend on CONFIG_DM_PWM,

> i.e. they are already guarded by Kconfig correctly.  Remove unneeded

> ifdef CONFIG_DM_PWM ... endif.

> 

> While we are here, let's tidy up alignment and sort the lines

> alphabetically in Makefile.

> 

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> Reviewed-by: Simon Glass <sjg@chromium.org>


Applied to u-boot/master, thanks!

-- 
Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile
index af39347..b037130 100644
--- a/drivers/pwm/Makefile
+++ b/drivers/pwm/Makefile
@@ -10,10 +10,9 @@ 
 
 #ccflags-y += -DDEBUG
 
-obj-$(CONFIG_DM_PWM) += pwm-uclass.o
-obj-$(CONFIG_PWM_ROCKCHIP) += rk_pwm.o
-obj-$(CONFIG_PWM_IMX) += pwm-imx.o pwm-imx-util.o
-ifdef CONFIG_DM_PWM
-obj-$(CONFIG_PWM_TEGRA) += tegra_pwm.o
-obj-$(CONFIG_PWM_EXYNOS) += exynos_pwm.o
-endif
+obj-$(CONFIG_DM_PWM)		+= pwm-uclass.o
+
+obj-$(CONFIG_PWM_EXYNOS)	+= exynos_pwm.o
+obj-$(CONFIG_PWM_IMX)		+= pwm-imx.o pwm-imx-util.o
+obj-$(CONFIG_PWM_ROCKCHIP)	+= rk_pwm.o
+obj-$(CONFIG_PWM_TEGRA)		+= tegra_pwm.o