| Message ID | 20170322180458.15567-1-fathi.boudra@linaro.org |
|---|---|
| State | Accepted |
| Commit | b13f76664d68b9b9fc0827c5dcfe6811232db5f7 |
| Headers | show |
| Series | [1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64 | expand |
Hi Fathi, On 22 March 2017 at 23:34, Fathi Boudra <fathi.boudra@linaro.org> wrote: > To build breakpoint_test_arm64, ARCH value is only tested for "aarch64". > It covers only the native build because it's computed from uname -m output. > For cross-compilation, ARCH is set to arm64 and prevent to cross-compile > the test. > Fix the test to allow both native and cross-compilation of the test. > > Note: glibc is missing several of the TRAP_* constants in the userspace > definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT. > See https://sourceware.org/bugzilla/show_bug.cgi?id=21286 > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > tools/testing/selftests/breakpoints/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile > index 72aa103e4141..6b214b7b10fb 100644 > --- a/tools/testing/selftests/breakpoints/Makefile > +++ b/tools/testing/selftests/breakpoints/Makefile > @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) > ifeq ($(ARCH),x86) > TEST_GEN_PROGS := breakpoint_test > endif > -ifeq ($(ARCH),aarch64) > +ifneq (,$(filter $(ARCH),aarch64 arm64)) > TEST_GEN_PROGS := breakpoint_test_arm64 > endif This patch works. Tested on arm64 Hikey development board running 4.9 kernel. Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org> - Naresh > > -- > 2.11.0 >
gentle ping On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote: > To build breakpoint_test_arm64, ARCH value is only tested for "aarch64". > It covers only the native build because it's computed from uname -m output. > For cross-compilation, ARCH is set to arm64 and prevent to cross-compile > the test. > Fix the test to allow both native and cross-compilation of the test. > > Note: glibc is missing several of the TRAP_* constants in the userspace > definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT. > See https://sourceware.org/bugzilla/show_bug.cgi?id=21286 > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > tools/testing/selftests/breakpoints/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile > index 72aa103e4141..6b214b7b10fb 100644 > --- a/tools/testing/selftests/breakpoints/Makefile > +++ b/tools/testing/selftests/breakpoints/Makefile > @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) > ifeq ($(ARCH),x86) > TEST_GEN_PROGS := breakpoint_test > endif > -ifeq ($(ARCH),aarch64) > +ifneq (,$(filter $(ARCH),aarch64 arm64)) > TEST_GEN_PROGS := breakpoint_test_arm64 > endif > > -- > 2.11.0 >
On 04/19/2017 11:31 AM, Fathi Boudra wrote: > gentle ping > > On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote: >> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64". >> It covers only the native build because it's computed from uname -m output. >> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile >> the test. >> Fix the test to allow both native and cross-compilation of the test. >> >> Note: glibc is missing several of the TRAP_* constants in the userspace >> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT. >> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286 >> >> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> I plan to get to it towards the end of this week. Thanks for the ping. -- Shuah >> --- >> tools/testing/selftests/breakpoints/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile >> index 72aa103e4141..6b214b7b10fb 100644 >> --- a/tools/testing/selftests/breakpoints/Makefile >> +++ b/tools/testing/selftests/breakpoints/Makefile >> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) >> ifeq ($(ARCH),x86) >> TEST_GEN_PROGS := breakpoint_test >> endif >> -ifeq ($(ARCH),aarch64) >> +ifneq (,$(filter $(ARCH),aarch64 arm64)) >> TEST_GEN_PROGS := breakpoint_test_arm64 >> endif >> >> -- >> 2.11.0 >> > >
On 04/19/2017 11:31 AM, Fathi Boudra wrote: > gentle ping > > On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote: >> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64". >> It covers only the native build because it's computed from uname -m output. >> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile >> the test. >> Fix the test to allow both native and cross-compilation of the test. >> >> Note: glibc is missing several of the TRAP_* constants in the userspace >> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT. >> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286 >> >> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> --- Applied to linux-kselftest next. thanks for the patch. -- Shuah
diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile index 72aa103e4141..6b214b7b10fb 100644 --- a/tools/testing/selftests/breakpoints/Makefile +++ b/tools/testing/selftests/breakpoints/Makefile @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) ifeq ($(ARCH),x86) TEST_GEN_PROGS := breakpoint_test endif -ifeq ($(ARCH),aarch64) +ifneq (,$(filter $(ARCH),aarch64 arm64)) TEST_GEN_PROGS := breakpoint_test_arm64 endif
To build breakpoint_test_arm64, ARCH value is only tested for "aarch64". It covers only the native build because it's computed from uname -m output. For cross-compilation, ARCH is set to arm64 and prevent to cross-compile the test. Fix the test to allow both native and cross-compilation of the test. Note: glibc is missing several of the TRAP_* constants in the userspace definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT. See https://sourceware.org/bugzilla/show_bug.cgi?id=21286 Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> --- tools/testing/selftests/breakpoints/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0