diff mbox series

[v2,for-4.9,02/32] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags

Message ID 1491388344-13521-3-git-send-email-amit.pundir@linaro.org
State Superseded
Headers show
Series Stable commits picked up from lede project | expand

Commit Message

Amit Pundir April 5, 2017, 10:31 a.m. UTC
From: Jon Mason <jon.mason@broadcom.com>


GIC_PPI flags were misconfigured for the timers, resulting in errors
like:
[    0.000000] GIC: PPI11 is secure or misconfigured

Changing them to being edge triggered corrects the issue

Suggested-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Jon Mason <jon.mason@broadcom.com>

Fixes: d27509f1 ("ARM: BCM5301X: add dts files for BCM4708 SoC")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

(cherry picked from commit 0c2bf9f95983fe30aa2f6463cb761cd42c2d521a)
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>

---
 arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

Comments

Greg KH April 6, 2017, 7:33 a.m. UTC | #1
On Wed, Apr 05, 2017 at 04:01:54PM +0530, Amit Pundir wrote:
> From: Jon Mason <jon.mason@broadcom.com>

> 

> GIC_PPI flags were misconfigured for the timers, resulting in errors

> like:

> [    0.000000] GIC: PPI11 is secure or misconfigured

> 

> Changing them to being edge triggered corrects the issue

> 

> Suggested-by: Rafał Miłecki <rafal@milecki.pl>

> Signed-off-by: Jon Mason <jon.mason@broadcom.com>

> Fixes: d27509f1 ("ARM: BCM5301X: add dts files for BCM4708 SoC")

> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

> (cherry picked from commit 0c2bf9f95983fe30aa2f6463cb761cd42c2d521a)

> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>

> ---

>  arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)


This also should go into 4.10-stable, right?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index ae4b388..4616452 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -66,14 +66,14 @@ 
 		timer@20200 {
 			compatible = "arm,cortex-a9-global-timer";
 			reg = <0x20200 0x100>;
-			interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
+			interrupts = <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>;
 			clocks = <&periph_clk>;
 		};
 
 		local-timer@20600 {
 			compatible = "arm,cortex-a9-twd-timer";
 			reg = <0x20600 0x100>;
-			interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
+			interrupts = <GIC_PPI 13 IRQ_TYPE_EDGE_RISING>;
 			clocks = <&periph_clk>;
 		};