From patchwork Thu Apr 20 07:38:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 97719 Delivered-To: patch@linaro.org Received: by 10.140.109.52 with SMTP id k49csp667490qgf; Thu, 20 Apr 2017 00:39:24 -0700 (PDT) X-Received: by 10.98.23.23 with SMTP id 23mr6751499pfx.30.1492673964105; Thu, 20 Apr 2017 00:39:24 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 203si1845905pgf.183.2017.04.20.00.39.23; Thu, 20 Apr 2017 00:39:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943105AbdDTHjV (ORCPT + 6 others); Thu, 20 Apr 2017 03:39:21 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:35914 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943104AbdDTHjU (ORCPT ); Thu, 20 Apr 2017 03:39:20 -0400 Received: by mail-oi0-f42.google.com with SMTP id r203so38485758oib.3 for ; Thu, 20 Apr 2017 00:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pJPpAxTCXAFWsJOMqb2N3RYGj35hZ9PAsgs24tOjD04=; b=e/tduMPmG1E59lCSIa2WuJfcbEunoTrJNzBRXdlBU86VdXWCF77I+4zkHKgX6UIjf7 8gg6NM3liQ1Heknu0d4OZJlMh0AP5qlXkJLTh6WI206iUydlSqS3QPnsUyTnrTKFgS4j QqNLrkMus3NsrmikZDeTwm5h3TRS/O/Bb/76M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pJPpAxTCXAFWsJOMqb2N3RYGj35hZ9PAsgs24tOjD04=; b=Gs3S1lik9x20RYjBqmMq83BmUj/HhEzSvxHWWf8PSDy9Hfd+rhF5O9Plvpoqq6tAPA fg9A5hWuJoSXFI23MVSppK1+Q/gsW4OH+3/zsMvW+xqVcoL/WUblB2EdI5MbnZ61hg7y FfdIluKnxj5/wzySPjTVE3oG0ojKjttAri7sx5sTf2o6I3GfTaWDL+upAyRnty2pD4qz axQhD7n93osk+OY4lowiG+c31J42gRHO8POZGHJDsY0tvgzMh5P3w0V1Y0Ox/tneCa6n ZZ3ldYo7+z3qofFPfhZt3ziY06GpVRZOXdFxVPBILQt4o/idd0yyxONfFQTr/whGESVQ zMrg== X-Gm-Message-State: AN3rC/4Am02gTb6XohOKLrUFsVu+jEj/vhglqDLNMzRfWdzSyUzg6wnC LyjM6l60IfHKnw/u X-Received: by 10.84.215.23 with SMTP id k23mr6880658pli.104.1492673944675; Thu, 20 Apr 2017 00:39:04 -0700 (PDT) Received: from phantom.lan ([106.51.225.38]) by smtp.gmail.com with ESMTPSA id t2sm8497717pfl.34.2017.04.20.00.39.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Apr 2017 00:39:03 -0700 (PDT) From: Sumit Semwal To: stable@vger.kernel.org Cc: Vitaly Kuznetsov , "K . Y . Srinivasan" , Greg Kroah-Hartman , Sumit Semwal Subject: [v3 PATCH for-4.4 4/7] Tools: hv: kvp: ensure kvp device fd is closed on exec Date: Thu, 20 Apr 2017 13:08:40 +0530 Message-Id: <1492673923-1352-5-git-send-email-sumit.semwal@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1492673923-1352-1-git-send-email-sumit.semwal@linaro.org> References: <1492673923-1352-1-git-send-email-sumit.semwal@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vitaly Kuznetsov [ Upstream commit 26840437cbd6d3625ea6ab34e17cd34bb810c861 ] KVP daemon does fork()/exec() (with popen()) so we need to close our fds to avoid sharing them with child processes. The immediate implication of not doing so I see is SELinux complaining about 'ip' trying to access '/dev/vmbus/hv_kvp'. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sumit Semwal --- tools/hv/hv_kvp_daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index 0d9f48e..bc7adb8 100644 --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -1433,7 +1433,7 @@ int main(int argc, char *argv[]) openlog("KVP", 0, LOG_USER); syslog(LOG_INFO, "KVP starting; pid is:%d", getpid()); - kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR); + kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR | O_CLOEXEC); if (kvp_fd < 0) { syslog(LOG_ERR, "open /dev/vmbus/hv_kvp failed; error: %d %s",