| Message ID | 20170509100502.1358298-2-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | [3.16-stable,01/14] staging: r8192ee: prorperly format warning message | expand |
diff --git a/drivers/staging/rtl8192ee/pci.c b/drivers/staging/rtl8192ee/pci.c index 3fe9b7ba01d6..1686b360e088 100644 --- a/drivers/staging/rtl8192ee/pci.c +++ b/drivers/staging/rtl8192ee/pci.c @@ -882,8 +882,8 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw) } else { if (err_count++ < 10) { - pr_info("skb->end (%d) - skb->tail (%d) > len (%d)\n", - skb->end, skb->tail, len); + pr_info("skb end: %d) - tailroom (%d) > len (%d)\n", + skb_end_offset(skb), skb_tailroom(skb), len); RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_EMERG, "RX desc\n", (u8 *)pdesc, 32);
In stable/linux-3.16.y, we get a warning for 64-bit architectures: drivers/staging/rtl8192ee/pci.c: In function '_rtl_pci_rx_interrupt': include/linux/kern_levels.h:4:18: warning: format '%d' expects argument of type 'int', but argument 2 has type 'sk_buff_data_t {aka unsigned char *}' [-Wformat=] include/linux/kern_levels.h:4:18: warning: format '%d' expects argument of type 'int', but argument 3 has type 'sk_buff_data_t {aka unsigned char *}' [-Wformat=] The driver was removed in 3.18 before this was fixed, so there is no workaround to backport, but it's easy enough to avoid the problem by changing the printk message to something similar that uses proper accessors for the skb fields. Fixes: 78de2c063710 ("staging: r8192ee: Add source files for core driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/rtl8192ee/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0