diff mbox series

[v1,1/1] linux-generic: crypto: don't leak sessions if creation fails

Message ID 1494374405-10131-2-git-send-email-odpbot@yandex.ru
State Superseded
Headers show
Series [v1,1/1] linux-generic: crypto: don't leak sessions if creation fails | expand

Commit Message

Github ODP bot May 10, 2017, midnight UTC 
From: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>


We should free allocated session in odp_crypto_session_create() error
paths, so that the session is not leaked.

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

---
/** Email created from pull request 25 (lumag:crypto-fix-create)
 ** https://github.com/Linaro/odp/pull/25
 ** Patch: https://github.com/Linaro/odp/pull/25.patch
 ** Base sha: 79ba737a404d2833ad33d8f84ed6ce82c9a8c18e
 ** Merge commit sha: 428c9ea1c0e80039547f12fa2a36bccd4c29be19
 **/
 platform/linux-generic/odp_crypto.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c
index b432f84..c5473d9 100644
--- a/platform/linux-generic/odp_crypto.c
+++ b/platform/linux-generic/odp_crypto.c
@@ -678,6 +678,7 @@  odp_crypto_session_create(odp_crypto_session_param_t *param,
 	if (session->p.iv.data) {
 		if (session->p.iv.length > MAX_IV_LEN) {
 			ODP_DBG("Maximum IV length exceeded\n");
+			free_session(session);
 			return -1;
 		}
 
@@ -724,6 +725,7 @@  odp_crypto_session_create(odp_crypto_session_param_t *param,
 	/* Check result */
 	if (rc) {
 		*status = ODP_CRYPTO_SES_CREATE_ERR_INV_CIPHER;
+		free_session(session);
 		return -1;
 	}
 
@@ -763,6 +765,7 @@  odp_crypto_session_create(odp_crypto_session_param_t *param,
 	/* Check result */
 	if (rc) {
 		*status = ODP_CRYPTO_SES_CREATE_ERR_INV_AUTH;
+		free_session(session);
 		return -1;
 	}